From 2fbc8509f5e2a57ca33e0b826d8ac25e845fd099 Mon Sep 17 00:00:00 2001 From: Shreya Shah Date: Thu, 28 Jun 2018 14:14:28 +0530 Subject: [PATCH] Fix error message (#14716) --- .../doctype/payment_entry/payment_entry.js | 40 ++++++++++--------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.js b/erpnext/accounts/doctype/payment_entry/payment_entry.js index c353e5eab7..940a709beb 100644 --- a/erpnext/accounts/doctype/payment_entry/payment_entry.js +++ b/erpnext/accounts/doctype/payment_entry/payment_entry.js @@ -819,28 +819,30 @@ frappe.ui.form.on('Payment Entry Reference', { reference_name: function(frm, cdt, cdn) { var row = locals[cdt][cdn]; - return frappe.call({ - method: "erpnext.accounts.doctype.payment_entry.payment_entry.get_reference_details", - args: { - reference_doctype: row.reference_doctype, - reference_name: row.reference_name, - party_account_currency: frm.doc.payment_type=="Receive" ? - frm.doc.paid_from_account_currency : frm.doc.paid_to_account_currency - }, - callback: function(r, rt) { - if(r.message) { - $.each(r.message, function(field, value) { - frappe.model.set_value(cdt, cdn, field, value); - }) + if (row.reference_name && row.reference_doctype) { + return frappe.call({ + method: "erpnext.accounts.doctype.payment_entry.payment_entry.get_reference_details", + args: { + reference_doctype: row.reference_doctype, + reference_name: row.reference_name, + party_account_currency: frm.doc.payment_type=="Receive" ? + frm.doc.paid_from_account_currency : frm.doc.paid_to_account_currency + }, + callback: function(r, rt) { + if(r.message) { + $.each(r.message, function(field, value) { + frappe.model.set_value(cdt, cdn, field, value); + }) - let allocated_amount = frm.doc.unallocated_amount > row.outstanding_amount ? - row.outstanding_amount : frm.doc.unallocated_amount; + let allocated_amount = frm.doc.unallocated_amount > row.outstanding_amount ? + row.outstanding_amount : frm.doc.unallocated_amount; - frappe.model.set_value(cdt, cdn, 'allocated_amount', allocated_amount); - frm.refresh_fields(); + frappe.model.set_value(cdt, cdn, 'allocated_amount', allocated_amount); + frm.refresh_fields(); + } } - } - }) + }) + } }, allocated_amount: function(frm) {