From 2f6d56dd6280d08ad2e3bcf7fac44419d9976e9c Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Thu, 29 Jun 2023 18:44:40 +0530 Subject: [PATCH] fix: don't update SCO status to closed until full return --- .../doctype/subcontracting_order/subcontracting_order.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py b/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py index 39197332c1..0b14d4d9f5 100644 --- a/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py +++ b/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py @@ -163,9 +163,10 @@ class SubcontractingOrder(SubcontractingController): elif self.per_received > 0 and self.per_received < 100: status = "Partially Received" for item in self.supplied_items: - if item.returned_qty: - status = "Closed" + if not item.returned_qty or (item.supplied_qty - item.consumed_qty - item.returned_qty) > 0: break + else: + status = "Closed" else: total_required_qty = total_supplied_qty = 0 for item in self.supplied_items: