Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Validatiion for loan write off amountt

Browse Source
This commit is contained in:
Deepesh Garg 2020-10-21 10:40:59 +05:30
parent 8cd8dbe15d
commit 2f65ab5355
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/loan_management/doctype/loan_write_off/loan_write_off.py
View File

@ -5,19 +5,28 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe, erpnext import frappe, erpnext
from frappe import _ from frappe import _
from frappe.utils import getdate from frappe.utils import getdate, flt
from frappe.model.document import Document
from erpnext.controllers.accounts_controller import AccountsController from erpnext.controllers.accounts_controller import AccountsController
from erpnext.accounts.general_ledger import make_gl_entries from erpnext.accounts.general_ledger import make_gl_entries
class LoanWriteOff(AccountsController): class LoanWriteOff(AccountsController):
def validate(self): def validate(self):
self.set_missing_values() self.set_missing_values()
self.validate_write_off_amount()
def set_missing_values(self): def set_missing_values(self):
if not self.cost_center: if not self.cost_center:
self.cost_center = erpnext.get_default_cost_center(self.company) self.cost_center = erpnext.get_default_cost_center(self.company)
def validate_write_off_amount(self):
total_payment, principal_paid, interest_payable, written_off_amount = frappe.get_value("Loan", self.loan,
['total_payment', 'total_principal_paid','total_interest_payable', 'written_off_amount'])
pending_principal_amount = flt(total_payment) - flt(interest_payable) - flt(principal_paid) - flt(written_off_amount)
if self.write_off_amount > pending_principal_amount:
frappe.throw(_("Write off amount cannot be greater than pending principal amount"))
def on_submit(self): def on_submit(self):
self.update_outstanding_amount() self.update_outstanding_amount()
self.make_gl_entries() self.make_gl_entries()