Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: defer holiday list imports

Browse Source 
Only used for configuring but loaded whenever
get_doc("holiday list", ...) is done
This commit is contained in:
Ankush Menat 2023-08-07 10:08:03 +05:30
parent 10a2191e3f
commit 2eea90a873
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/setup/doctype/holiday_list/holiday_list.py
View File

@ -9,8 +9,6 @@ import frappe
from frappe import _, throw from frappe import _, throw
from frappe.model.document import Document from frappe.model.document import Document
from frappe.utils import formatdate, getdate, today from frappe.utils import formatdate, getdate, today
from holidays import country_holidays
from holidays.utils import list_supported_countries
class OverlapError(frappe.ValidationError): class OverlapError(frappe.ValidationError):
@ -39,6 +37,8 @@ class HolidayList(Document):
@frappe.whitelist() @frappe.whitelist()
def get_supported_countries(self): def get_supported_countries(self):
from holidays.utils import list_supported_countries
subdivisions_by_country = list_supported_countries() subdivisions_by_country = list_supported_countries()
countries = [ countries = [
{"value": country, "label": local_country_name(country)} {"value": country, "label": local_country_name(country)}
@ -51,6 +51,8 @@ class HolidayList(Document):
@frappe.whitelist() @frappe.whitelist()
def get_local_holidays(self): def get_local_holidays(self):
from holidays import country_holidays
if not self.country: if not self.country:
throw(_("Please select a country")) throw(_("Please select a country"))