From b338b6ed24fb6dff3e23139eb8f4ec1153e88b2b Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 15 Oct 2013 16:55:24 +0530 Subject: [PATCH 1/6] [fix] [minor] validate converion rate --- accounts/doctype/sales_invoice/sales_invoice.py | 1 - public/js/transaction.js | 3 +-- selling/doctype/quotation/quotation.py | 2 -- selling/doctype/sales_common/sales_common.py | 15 --------------- selling/doctype/sales_order/sales_order.py | 2 +- stock/doctype/delivery_note/delivery_note.py | 2 +- 6 files changed, 3 insertions(+), 22 deletions(-) diff --git a/accounts/doctype/sales_invoice/sales_invoice.py b/accounts/doctype/sales_invoice/sales_invoice.py index daf01ab801..3ae74e481e 100644 --- a/accounts/doctype/sales_invoice/sales_invoice.py +++ b/accounts/doctype/sales_invoice/sales_invoice.py @@ -52,7 +52,6 @@ class DocType(SellingController): sales_com_obj = get_obj('Sales Common') sales_com_obj.check_stop_sales_order(self) sales_com_obj.check_active_sales_items(self) - sales_com_obj.check_conversion_rate(self) sales_com_obj.validate_max_discount(self, 'entries') self.validate_customer_account() self.validate_debit_acc() diff --git a/public/js/transaction.js b/public/js/transaction.js index 79ea53623f..3cb40514a8 100644 --- a/public/js/transaction.js +++ b/public/js/transaction.js @@ -173,8 +173,7 @@ erpnext.TransactionController = erpnext.stock.StockController.extend({ this.frm.doc.plc_conversion_rate !== this.frm.doc.conversion_rate) { this.frm.set_value("plc_conversion_rate", this.frm.doc.conversion_rate); } - - this.calculate_taxes_and_totals(); + if(flt(this.frm.doc.conversion_rate)>0.0) this.calculate_taxes_and_totals(); }, get_price_list_currency: function(buying_or_selling) { diff --git a/selling/doctype/quotation/quotation.py b/selling/doctype/quotation/quotation.py index 8eb3654e62..8209548fcb 100644 --- a/selling/doctype/quotation/quotation.py +++ b/selling/doctype/quotation/quotation.py @@ -111,8 +111,6 @@ class DocType(SellingController): sales_com_obj = get_obj('Sales Common') sales_com_obj.check_active_sales_items(self) sales_com_obj.validate_max_discount(self,'quotation_details') - sales_com_obj.check_conversion_rate(self) - def on_update(self): # Set Quotation Status diff --git a/selling/doctype/sales_common/sales_common.py b/selling/doctype/sales_common/sales_common.py index 8271c82874..ad626da460 100644 --- a/selling/doctype/sales_common/sales_common.py +++ b/selling/doctype/sales_common/sales_common.py @@ -74,21 +74,6 @@ class DocType(TransactionBase): msgprint("You cannot give more than " + cstr(discount[0]['max_discount']) + " % discount on Item Code : "+cstr(d.item_code)) raise Exception - # Check Conversion Rate (i.e. it will not allow conversion rate to be 1 for Currency other than default currency set in Global Defaults) - # =========================================================================== - def check_conversion_rate(self, obj): - default_currency = get_company_currency(obj.doc.company) - if not default_currency: - msgprint('Message: Please enter default currency in Company Master') - raise Exception - if (obj.doc.currency == default_currency and flt(obj.doc.conversion_rate) != 1.00) or not obj.doc.conversion_rate or (obj.doc.currency != default_currency and flt(obj.doc.conversion_rate) == 1.00): - msgprint("Please Enter Appropriate Conversion Rate for Customer's Currency to Base Currency (%s --> %s)" % (obj.doc.currency, default_currency), raise_exception = 1) - - if (obj.doc.price_list_currency == default_currency and flt(obj.doc.plc_conversion_rate) != 1.00) or not obj.doc.plc_conversion_rate or (obj.doc.price_list_currency != default_currency and flt(obj.doc.plc_conversion_rate) == 1.00): - msgprint("Please Enter Appropriate Conversion Rate for Price List Currency to Base Currency (%s --> %s)" % (obj.doc.price_list_currency, default_currency), raise_exception = 1) - - - # Get Tax rate if account type is TAX # ========================================================================= def get_rate(self, arg): diff --git a/selling/doctype/sales_order/sales_order.py b/selling/doctype/sales_order/sales_order.py index 435a9768aa..66b487e450 100644 --- a/selling/doctype/sales_order/sales_order.py +++ b/selling/doctype/sales_order/sales_order.py @@ -130,7 +130,7 @@ class DocType(SellingController): self.validate_warehouse() sales_com_obj = get_obj(dt = 'Sales Common') sales_com_obj.check_active_sales_items(self) - sales_com_obj.check_conversion_rate(self) + sales_com_obj.validate_max_discount(self,'sales_order_details') self.doclist = sales_com_obj.make_packing_list(self,'sales_order_details') diff --git a/stock/doctype/delivery_note/delivery_note.py b/stock/doctype/delivery_note/delivery_note.py index 2d1a3bece6..eb2b204d0c 100644 --- a/stock/doctype/delivery_note/delivery_note.py +++ b/stock/doctype/delivery_note/delivery_note.py @@ -95,7 +95,7 @@ class DocType(SellingController): self.validate_uom_is_integer("stock_uom", "qty") sales_com_obj.validate_max_discount(self, 'delivery_note_details') - sales_com_obj.check_conversion_rate(self) + # Set actual qty for each item in selected warehouse self.update_current_stock() From fc75d96abd69fc2620c0f61137b6ab8ae46ee8d9 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 16 Oct 2013 11:48:15 +0530 Subject: [PATCH 2/6] [fix] [minor] Purchase Invoice - Amount for Stock received but not billed --- accounts/doctype/purchase_invoice/purchase_invoice.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/accounts/doctype/purchase_invoice/purchase_invoice.py b/accounts/doctype/purchase_invoice/purchase_invoice.py index 3c3bcb7022..58101da2ad 100644 --- a/accounts/doctype/purchase_invoice/purchase_invoice.py +++ b/accounts/doctype/purchase_invoice/purchase_invoice.py @@ -367,9 +367,8 @@ class DocType(BuyingController): # expense will be booked in sales invoice stock_item_and_auto_accounting_for_stock = True - valuation_amt = (flt(item.amount, self.precision("amount", item)) + - flt(item.item_tax_amount, self.precision("item_tax_amount", item)) + - flt(item.rm_supp_cost, self.precision("rm_supp_cost", item))) + valuation_amt = flt(item.valuation_rate) * flt(item.qty) * \ + flt(item.conversion_factor) gl_entries.append( self.get_gl_dict({ From 185991d54796a41e13527ef59418102af2e7a417 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 16 Oct 2013 13:08:53 +0530 Subject: [PATCH 3/6] [fix] [minor] rounding error in purchase invoice gl entry --- .../doctype/purchase_invoice/purchase_invoice.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/accounts/doctype/purchase_invoice/purchase_invoice.py b/accounts/doctype/purchase_invoice/purchase_invoice.py index 58101da2ad..c1e92b9f4f 100644 --- a/accounts/doctype/purchase_invoice/purchase_invoice.py +++ b/accounts/doctype/purchase_invoice/purchase_invoice.py @@ -359,6 +359,7 @@ class DocType(BuyingController): # item gl entries stock_item_and_auto_accounting_for_stock = False stock_items = self.get_stock_items() + rounding_diff = 0.0 for item in self.doclist.get({"parentfield": "entries"}): if auto_accounting_for_stock and item.item_code in stock_items: if flt(item.valuation_rate): @@ -367,8 +368,13 @@ class DocType(BuyingController): # expense will be booked in sales invoice stock_item_and_auto_accounting_for_stock = True - valuation_amt = flt(item.valuation_rate) * flt(item.qty) * \ - flt(item.conversion_factor) + valuation_amt = flt(flt(item.valuation_rate) * flt(item.qty) * \ + flt(item.conversion_factor), self.precision("valuation_rate", item)) + + rounding_diff += (flt(item.amount, self.precision("amount", item)) + + flt(item.item_tax_amount, self.precision("item_tax_amount", item)) + + flt(item.rm_supp_cost, self.precision("rm_supp_cost", item)) - + valuation_amt) gl_entries.append( self.get_gl_dict({ @@ -397,6 +403,12 @@ class DocType(BuyingController): expenses_included_in_valuation = \ self.get_company_default("expenses_included_in_valuation") + if rounding_diff: + import operator + cost_center_with_max_value = max(valuation_tax.iteritems(), + key=operator.itemgetter(1))[0] + valuation_tax[cost_center_with_max_value] -= flt(rounding_diff) + for cost_center, amount in valuation_tax.items(): gl_entries.append( self.get_gl_dict({ From ccbde214c2845fbbcebcf015870bc1ca8b16f0fb Mon Sep 17 00:00:00 2001 From: Maxwell Date: Wed, 16 Oct 2013 16:52:01 -0300 Subject: [PATCH 4/6] Fix UnicodeDecodeError ```python Traceback (most recent call last): File "install_erpnext.py", line 348, in install() File "install_erpnext.py", line 13, in install install_pre_requisites() File "install_erpnext.py", line 25, in install_pre_requisites install_using_yum() File "install_erpnext.py", line 90, in install_using_yum update_config_for_redhat() File "install_erpnext.py", line 106, in update_config_for_redhat exec_in_shell("chkconfig --level 2345 %s on" % service) File "install_erpnext.py", line 339, in exec_in_shell if err and any((kw in err.lower() for kw in ["traceback", "error", "exception"])): File "install_erpnext.py", line 339, in if err and any((kw in err.lower() for kw in ["traceback", "error", "exception"])): ``` --- install_erpnext.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/install_erpnext.py b/install_erpnext.py index 79f79d7cc0..7f3b8c3b65 100644 --- a/install_erpnext.py +++ b/install_erpnext.py @@ -332,9 +332,11 @@ def exec_in_shell(cmd): stdout.seek(0) out = stdout.read() + if out: out = out.decode('utf-8') stderr.seek(0) err = stderr.read() + if err: err = err.decode('utf-8') if err and any((kw in err.lower() for kw in ["traceback", "error", "exception"])): print out @@ -345,4 +347,4 @@ def exec_in_shell(cmd): return out if __name__ == "__main__": - install() \ No newline at end of file + install() From 564c621c3ecadf452689ba2ab909250dfdcd1457 Mon Sep 17 00:00:00 2001 From: Akhilesh Darjee Date: Thu, 17 Oct 2013 11:31:11 +0530 Subject: [PATCH 5/6] [fix] [minor] conversion rate fix --- public/js/transaction.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/public/js/transaction.js b/public/js/transaction.js index e32fe1533e..4ff583016c 100644 --- a/public/js/transaction.js +++ b/public/js/transaction.js @@ -26,7 +26,7 @@ erpnext.TransactionController = erpnext.stock.StockController.extend({ me.frm.set_value(fieldname, value); }); } - + if(this.other_fname) { this[this.other_fname + "_remove"] = this.calculate_taxes_and_totals; } @@ -46,6 +46,7 @@ erpnext.TransactionController = erpnext.stock.StockController.extend({ freeze: true, callback: function(r) { // remove this call when using client side mapper + me.frm.script_manager.trigger("company"); me.set_default_values(); me.set_dynamic_labels(); me.calculate_taxes_and_totals() @@ -226,7 +227,8 @@ erpnext.TransactionController = erpnext.stock.StockController.extend({ plc_conversion_rate: function() { if(this.frm.doc.price_list_currency === this.get_company_currency()) { this.frm.set_value("plc_conversion_rate", 1.0); - } else if(this.frm.doc.price_list_currency === this.frm.doc.currency) { + } + if(this.frm.doc.price_list_currency === this.frm.doc.currency) { this.frm.set_value("conversion_rate", this.frm.doc.plc_conversion_rate); this.calculate_taxes_and_totals(); } From 3add576b1ea54e18f3d76f618cab0d131f025b8e Mon Sep 17 00:00:00 2001 From: Akhilesh Darjee Date: Thu, 17 Oct 2013 11:32:44 +0530 Subject: [PATCH 6/6] [fix] [minor] conversion rate fix --- public/js/transaction.js | 1 - 1 file changed, 1 deletion(-) diff --git a/public/js/transaction.js b/public/js/transaction.js index 4ff583016c..c1b83702d6 100644 --- a/public/js/transaction.js +++ b/public/js/transaction.js @@ -46,7 +46,6 @@ erpnext.TransactionController = erpnext.stock.StockController.extend({ freeze: true, callback: function(r) { // remove this call when using client side mapper - me.frm.script_manager.trigger("company"); me.set_default_values(); me.set_dynamic_labels(); me.calculate_taxes_and_totals()