Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(minor): student_attendance_tool.js fix fetching UX

Browse Source
This commit is contained in:
Rushabh Mehta 2022-02-26 11:32:54 +05:30
parent 1e7df5d0c2
commit 2dabda03af
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/education/doctype/student_attendance_tool/student_attendance_tool.js
View File

@ -3,6 +3,10 @@
frappe.provide("education"); frappe.provide("education");
frappe.ui.form.on('Student Attendance Tool', { frappe.ui.form.on('Student Attendance Tool', {
setup: (frm) => {
frm.students_area = $('<div>')
.appendTo(frm.fields_dict.students_html.wrapper);
},
onload: function(frm) { onload: function(frm) {
frm.set_query("student_group", function() { frm.set_query("student_group", function() {
return { return {
@ -34,6 +38,7 @@ frappe.ui.form.on('Student Attendance Tool', {
student_group: function(frm) { student_group: function(frm) {
if ((frm.doc.student_group && frm.doc.date) || frm.doc.course_schedule) { if ((frm.doc.student_group && frm.doc.date) || frm.doc.course_schedule) {
frm.students_area.find('.student-attendance-checks').html(`<div style='padding: 2rem 0'>Fetching...</div>`);
var method = "erpnext.education.doctype.student_attendance_tool.student_attendance_tool.get_student_attendance_records"; var method = "erpnext.education.doctype.student_attendance_tool.student_attendance_tool.get_student_attendance_records";
frappe.call({ frappe.call({
@ -62,10 +67,6 @@ frappe.ui.form.on('Student Attendance Tool', {
}, },
get_students: function(frm, students) { get_students: function(frm, students) {
if (!frm.students_area) {
frm.students_area = $('<div>')
.appendTo(frm.fields_dict.students_html.wrapper);
}
students = students || []; students = students || [];
frm.students_editor = new education.StudentsEditor(frm, frm.students_area, students); frm.students_editor = new education.StudentsEditor(frm, frm.students_area, students);
} }
@ -182,7 +183,7 @@ education.StudentsEditor = class StudentsEditor {
</div>`; </div>`;
} }
$(student_html).appendTo(me.wrapper); $(`<div class='student-attendance-checks'>${student_html}</div>`).appendTo(me.wrapper);
} }
show_empty_state() { show_empty_state() {