Merge pull request #34440 from s-aga-r/FIX-34354

chore: `Allow Zero Valuation Rate` msg in SE
This commit is contained in:
Sagar Sharma 2023-03-17 16:02:52 +05:30 committed by GitHub
commit 2ac079210d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -658,6 +658,7 @@ class StockEntry(StockController):
) )
finished_item_qty = sum(d.transfer_qty for d in self.items if d.is_finished_item) finished_item_qty = sum(d.transfer_qty for d in self.items if d.is_finished_item)
items = []
# Set basic rate for incoming items # Set basic rate for incoming items
for d in self.get("items"): for d in self.get("items"):
if d.s_warehouse or d.set_basic_rate_manually: if d.s_warehouse or d.set_basic_rate_manually:
@ -665,12 +666,7 @@ class StockEntry(StockController):
if d.allow_zero_valuation_rate: if d.allow_zero_valuation_rate:
d.basic_rate = 0.0 d.basic_rate = 0.0
frappe.msgprint( items.append(d.item_code)
_(
"Row {0}: Item rate has been updated to zero as Allow Zero Valuation Rate is checked for item {1}"
).format(d.idx, d.item_code),
alert=1,
)
elif d.is_finished_item: elif d.is_finished_item:
if self.purpose == "Manufacture": if self.purpose == "Manufacture":
@ -697,6 +693,20 @@ class StockEntry(StockController):
d.basic_rate = flt(d.basic_rate) d.basic_rate = flt(d.basic_rate)
d.basic_amount = flt(flt(d.transfer_qty) * flt(d.basic_rate), d.precision("basic_amount")) d.basic_amount = flt(flt(d.transfer_qty) * flt(d.basic_rate), d.precision("basic_amount"))
if items:
message = ""
if len(items) > 1:
message = _(
"Items rate has been updated to zero as Allow Zero Valuation Rate is checked for the following items: {0}"
).format(", ".join(frappe.bold(item) for item in items))
else:
message = _(
"Item rate has been updated to zero as Allow Zero Valuation Rate is checked for item {0}"
).format(frappe.bold(items[0]))
frappe.msgprint(message, alert=True)
def set_rate_for_outgoing_items(self, reset_outgoing_rate=True, raise_error_if_no_rate=True): def set_rate_for_outgoing_items(self, reset_outgoing_rate=True, raise_error_if_no_rate=True):
outgoing_items_cost = 0.0 outgoing_items_cost = 0.0
for d in self.get("items"): for d in self.get("items"):