Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: validation message of quality inspection in purchase receipt (#25666)

Browse Source
This commit is contained in:
rohitwaghchaure 2021-05-14 12:34:50 +05:30 committed by GitHub
parent 98fc4195b3
commit 2aa401826e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/controllers/stock_controller.py
View File

@ -379,8 +379,7 @@ class StockController(AccountsController):
link = frappe.utils.get_link_to_form('Quality Inspection', d.quality_inspection) link = frappe.utils.get_link_to_form('Quality Inspection', d.quality_inspection)
frappe.throw(_("Quality Inspection: {0} is not submitted for the item: {1} in row {2}").format(link, d.item_code, d.idx), QualityInspectionNotSubmittedError) frappe.throw(_("Quality Inspection: {0} is not submitted for the item: {1} in row {2}").format(link, d.item_code, d.idx), QualityInspectionNotSubmittedError)
qa_failed = any([r.status=="Rejected" for r in qa_doc.readings]) if qa_doc.status != 'Accepted':
if qa_failed:
frappe.throw(_("Row {0}: Quality Inspection rejected for item {1}") frappe.throw(_("Row {0}: Quality Inspection rejected for item {1}")
.format(d.idx, d.item_code), QualityInspectionRejectedError) .format(d.idx, d.item_code), QualityInspectionRejectedError)
elif qa_required : elif qa_required :

3
erpnext/stock/doctype/quality_inspection/test_quality_inspection.py
View File

@ -27,10 +27,11 @@ class TestQualityInspection(unittest.TestCase):
dn.reload() dn.reload()
self.assertRaises(QualityInspectionRejectedError, dn.submit) self.assertRaises(QualityInspectionRejectedError, dn.submit)
frappe.db.set_value("Quality Inspection Reading", {"parent": qa.name}, "status", "Accepted") frappe.db.set_value("Quality Inspection", qa.name, "status", "Accepted")
dn.reload() dn.reload()
dn.submit() dn.submit()
qa.reload()
qa.cancel() qa.cancel()
dn.reload() dn.reload()
dn.cancel() dn.cancel()