Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug fix: strip serial no field before validation to check truthy value

Browse Source
This commit is contained in:
Anand Doshi 2012-07-31 13:57:06 +05:30
parent 0029ac9f3c
commit 29c8b3b487
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/stock/doctype/stock_ledger/stock_ledger.py
View File

@ -87,13 +87,17 @@ class DocType:
for d in getlist(obj.doclist, fname): for d in getlist(obj.doclist, fname):
is_stock_item = get_value('Item', d.item_code, 'is_stock_item') is_stock_item = get_value('Item', d.item_code, 'is_stock_item')
ar_required = get_value('Item', d.item_code, 'has_serial_no') ar_required = get_value('Item', d.item_code, 'has_serial_no')
if cstr(d.serial_no).strip():
# [bug fix] need to strip serial nos of all spaces and new lines for validation
serial_no = cstr(d.serial_no).strip()
if serial_no:
if is_stock_item != 'Yes': if is_stock_item != 'Yes':
msgprint("Serial No is not required for non-stock item: %s" % d.item_code, raise_exception=1) msgprint("Serial No is not required for non-stock item: %s" % d.item_code, raise_exception=1)
elif ar_required != 'Yes': elif ar_required != 'Yes':
msgprint("If serial no required, please select 'Yes' in 'Has Serial No' in Item :" + d.item_code + \ msgprint("If serial no required, please select 'Yes' in 'Has Serial No' in Item :" + d.item_code + \
', otherwise please remove serial no', raise_exception=1) ', otherwise please remove serial no', raise_exception=1)
elif ar_required == 'Yes' and not d.serial_no: elif ar_required == 'Yes' and not serial_no:
msgprint("Serial no is mandatory for item: "+ d.item_code, raise_exception = 1) msgprint("Serial no is mandatory for item: "+ d.item_code, raise_exception = 1)
# validate rejected serial nos # validate rejected serial nos