From 28d182af15ee3b8780925832b71c43bff258c0d7 Mon Sep 17 00:00:00 2001 From: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Date: Thu, 19 Sep 2019 11:13:22 +0530 Subject: [PATCH] fix: Permission issue in Total Stock Summary report (#19110) Data in "Total Stock Summary" report were not getting filtered based on applied user permissions because some link fields had wrong options --- .../stock/report/total_stock_summary/total_stock_summary.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/stock/report/total_stock_summary/total_stock_summary.py b/erpnext/stock/report/total_stock_summary/total_stock_summary.py index b25e096974..41e2f86f29 100644 --- a/erpnext/stock/report/total_stock_summary/total_stock_summary.py +++ b/erpnext/stock/report/total_stock_summary/total_stock_summary.py @@ -15,8 +15,8 @@ def execute(filters=None): def get_columns(): columns = [ - _("Company") + ":Link/Item:250", - _("Warehouse") + ":Link/Item:150", + _("Company") + ":Link/Company:250", + _("Warehouse") + ":Link/Warehouse:150", _("Item") + ":Link/Item:150", _("Description") + "::300", _("Current Qty") + ":Float:100", @@ -30,7 +30,7 @@ def get_total_stock(filters): if filters.get("group_by") == "Warehouse": if filters.get("company"): - conditions += " AND warehouse.company = %s" % frappe.db.escape(filters.get("company"), percent=False) + conditions += " AND warehouse.company = '%s'" % frappe.db.escape(filters.get("company"), percent=False) conditions += " GROUP BY ledger.warehouse, item.item_code" columns += "'' as company, ledger.warehouse"