From 282a5b27adec89bf449f7006408a69aaf435d5ed Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Mon, 4 Dec 2023 12:18:58 +0530 Subject: [PATCH] fix: don't show non-stock items in Stock Analytics report (backport #38543) (#38545) * fix(ux): stock-item filter for Item Code field (cherry picked from commit ccdcb7dfcc29eb68d1cad38f3426e6fb575528eb) * fix: don't show non-stock items in Stock Analytics report (cherry picked from commit 01aadbef85e2570399f054027e57d6bb01af9433) --------- Co-authored-by: s-aga-r --- erpnext/stock/report/stock_analytics/stock_analytics.js | 1 + erpnext/stock/report/stock_analytics/stock_analytics.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/report/stock_analytics/stock_analytics.js b/erpnext/stock/report/stock_analytics/stock_analytics.js index ea7bf5688e..e033fd9a9d 100644 --- a/erpnext/stock/report/stock_analytics/stock_analytics.js +++ b/erpnext/stock/report/stock_analytics/stock_analytics.js @@ -17,6 +17,7 @@ frappe.query_reports["Stock Analytics"] = { fieldtype: "Link", options:"Item", default: "", + get_query: () => ({filters: { 'is_stock_item': 1 }}), }, { fieldname: "value_quantity", diff --git a/erpnext/stock/report/stock_analytics/stock_analytics.py b/erpnext/stock/report/stock_analytics/stock_analytics.py index 6c5b58c6e4..ab48181c48 100644 --- a/erpnext/stock/report/stock_analytics/stock_analytics.py +++ b/erpnext/stock/report/stock_analytics/stock_analytics.py @@ -270,7 +270,7 @@ def get_items(filters): if item_code := filters.get("item_code"): return [item_code] else: - item_filters = {} + item_filters = {"is_stock_item": 1} if item_group := filters.get("item_group"): children = get_descendants_of("Item Group", item_group, ignore_permissions=True) item_filters["item_group"] = ("in", children + [item_group])