Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve mode_of_payment validate_accounts

Browse Source 
using frappe.db.get_value instead of frappe.get_list
This commit is contained in:
Revant Nandgaonkar 2015-11-18 13:28:09 +05:30
parent 11f8a0033a
commit 27c266b081
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py
View File

@ -24,13 +24,5 @@ class ModeofPayment(Document):
def validate_accounts(self): def validate_accounts(self):
for entry in self.accounts: for entry in self.accounts:
"""Error when Company of Ledger account doesn't match with Company Selected""" """Error when Company of Ledger account doesn't match with Company Selected"""
account = frappe.get_list("Account", if frappe.db.get_value("Account", entry.default_account, "company") != entry.company:
fields=["name"],
filters = {
"company": entry.company,
"name": entry.default_account
})
try:
account[0].name
except IndexError:
frappe.throw(_("Account does not match with Company")) frappe.throw(_("Account does not match with Company"))