Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: simplify sort condition

Browse Source
This commit is contained in:
Rushabh Mehta 2019-05-02 09:22:48 +05:30
parent 7ca243094e
commit 27a30c842d
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/report/financial_statements.py
View File

@ -331,12 +331,8 @@ def sort_accounts(accounts, is_root=False, key="name"):
if a.root_type == "Income" and b.root_type == "Expense": if a.root_type == "Income" and b.root_type == "Expense":
return -1 return -1
else: else:
if re.split('\W+', a[key])[0].isdigit(): # sort by key (number) or name
# if chart of accounts is numbered, then sort by number return cmp(a[key], b[key])
return cmp(a[key], b[key])
else:
# common, this should be alphabetic otherwise!
return cmp(a[key], b[key])
return 1 return 1
accounts.sort(key = functools.cmp_to_key(compare_accounts)) accounts.sort(key = functools.cmp_to_key(compare_accounts))