Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: groupby using keys instead of int index

Browse Source
This commit is contained in:
Ankush Menat 2022-04-25 15:02:08 +05:30
parent 3ddad6891a
commit 277b51b404
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/stock/doctype/pick_list/pick_list.py
View File

@ -4,7 +4,6 @@
import json
from collections import OrderedDict, defaultdict
from itertools import groupby
from operator import itemgetter
from typing import Dict, List, Set
import frappe
@ -507,11 +506,13 @@ def create_delivery_note(source_name, target_doc=None):
for location in pick_list.locations:
if location.sales_order:
sales_orders.append(
[frappe.db.get_value("Sales Order", location.sales_order, "customer"), location.sales_order]
frappe.db.get_value(
"Sales Order", location.sales_order, ["customer", "name as sales_order"], as_dict=True
)
)
# Group sales orders by customer
for key, keydata in groupby(sales_orders, key=itemgetter(0)):
sales_dict[key] = set([d[1] for d in keydata])
for customer, rows in groupby(sales_orders, key=lambda so: so["customer"]):
sales_dict[customer] = {row.sales_order for row in rows}
if sales_dict:
delivery_note = create_dn_with_so(sales_dict, pick_list)