Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: get items for leaderboard

Browse Source
This commit is contained in:
barredterra 2023-12-11 19:34:24 +01:00
parent 137b5a6108
commit 2721ee3a8d
1 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
erpnext/startup/leaderboard.py
View File

@ -91,45 +91,46 @@ def get_all_customers(date_range, company, field, limit=None):
def get_all_items(date_range, company, field, limit=None): def get_all_items(date_range, company, field, limit=None):
if field in ("available_stock_qty", "available_stock_value"): if field in ("available_stock_qty", "available_stock_value"):
select_field = "sum(actual_qty)" if field == "available_stock_qty" else "sum(stock_value)" select_field = "sum(actual_qty)" if field == "available_stock_qty" else "sum(stock_value)"
return frappe.db.get_all( results = frappe.db.get_all(
"Bin", "Bin",
fields=["item_code as name", "{0} as value".format(select_field)], fields=["item_code as name", "{0} as value".format(select_field)],
group_by="item_code", group_by="item_code",
order_by="value desc", order_by="value desc",
limit=limit, limit=limit,
) )
readable_active_items = set(frappe.get_list("Item", filters={"disabled": 0}, pluck="name"))
return [item for item in results if item["name"] in readable_active_items]
else: else:
if field == "total_sales_amount": if field == "total_sales_amount":
select_field = "sum(order_item.base_net_amount)" select_field = "base_net_amount"
select_doctype = "Sales Order" select_doctype = "Sales Order"
elif field == "total_purchase_amount": elif field == "total_purchase_amount":
select_field = "sum(order_item.base_net_amount)" select_field = "base_net_amount"
select_doctype = "Purchase Order" select_doctype = "Purchase Order"
elif field == "total_qty_sold": elif field == "total_qty_sold":
select_field = "sum(order_item.stock_qty)" select_field = "stock_qty"
select_doctype = "Sales Order" select_doctype = "Sales Order"
elif field == "total_qty_purchased": elif field == "total_qty_purchased":
select_field = "sum(order_item.stock_qty)" select_field = "stock_qty"
select_doctype = "Purchase Order" select_doctype = "Purchase Order"
date_condition = get_date_condition(date_range, "sales_order.transaction_date") filters = [["docstatus", "=", "1"], ["company", "=", company]]
from_date, to_date = parse_date_range(date_range)
if from_date and to_date:
filters.append(["transaction_date", "between", [from_date, to_date]])
return frappe.db.sql( child_doctype = f"{select_doctype} Item"
""" return frappe.get_list(
select order_item.item_code as name, {0} as value select_doctype,
from `tab{1}` sales_order join `tab{1} Item` as order_item fields=[
on sales_order.name = order_item.parent f"`tab{child_doctype}`.item_code as name",
where sales_order.docstatus = 1 f"sum(`tab{child_doctype}`.{select_field}) as value",
and sales_order.company = %s {2} ],
group by order_item.item_code filters=filters,
order by value desc order_by="value desc",
limit %s group_by=f"`tab{child_doctype}`.item_code",
""".format( limit=limit,
select_field, select_doctype, date_condition )
),
(company, cint(limit)),
as_dict=1,
) # nosec
@frappe.whitelist() @frappe.whitelist()