Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: Weed out disabled variants via sql query instead of pythonic looping separately

Browse Source 
- If the number of variants are large (almost 2lakhs), the query to get variants and attribute data takes time
- If the no.of disabled attributes is large as well, the list comprehension weeding out disabled variants takes forever
- We dont need to loop over the variants data so many times
- Avoid any `if a in list(b)` is best when the iterables have tremendous data
This commit is contained in:
marination 2022-02-04 17:34:56 +05:30
parent 79ab8e6459
commit 26bd3053d1
1 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
erpnext/e_commerce/variant_selector/item_variants_cache.py
View File

@ -66,25 +66,39 @@ class ItemVariantsCacheManager:
) )
] ]
# join with Website Item # Get Variants and tehir Attributes that are not disabled
item_variants_data = frappe.get_all( iva = frappe.qb.DocType("Item Variant Attribute")
'Item Variant Attribute', item = frappe.qb.DocType("Item")
{'variant_of': parent_item_code}, query = (
['parent', 'attribute', 'attribute_value'], frappe.qb.from_(iva)
order_by='name', .join(item).on(item.name == iva.parent)
as_list=1 .select(
iva.parent, iva.attribute, iva.attribute_value
).where(
(iva.variant_of == parent_item_code)
& (item.disabled == 0)
).orderby(iva.name)
) )
item_variants_data = query.run()
disabled_items = set( # item_variants_data = frappe.get_all(
[i.name for i in frappe.db.get_all('Item', {'disabled': 1})] # 'Item Variant Attribute',
) # {'variant_of': parent_item_code},
# ['parent', 'attribute', 'attribute_value'],
# order_by='name',
# as_list=1
# )
# disabled_items = set(
# [i.name for i in frappe.db.get_all('Item', {'disabled': 1})]
# )
attribute_value_item_map = frappe._dict() attribute_value_item_map = frappe._dict()
item_attribute_value_map = frappe._dict() item_attribute_value_map = frappe._dict()
# dont consider variants that are disabled # dont consider variants that are disabled
# pull all other variants # pull all other variants
item_variants_data = [r for r in item_variants_data if r[0] not in disabled_items] # item_variants_data = [r for r in item_variants_data if r[0] not in disabled_items]
for row in item_variants_data: for row in item_variants_data:
item_code, attribute, attribute_value = row item_code, attribute, attribute_value = row