From 26569b2162564903a116e85666576f35dfb746da Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Fri, 31 Mar 2023 13:12:19 +0530 Subject: [PATCH] fix: Stock Reservation validation for SO --- erpnext/controllers/stock_controller.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 507deae42c..58891c113f 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -791,11 +791,6 @@ class StockController(AccountsController): if not self.get("reserve_stock"): return - if self.doctype != "Sales Order": - frappe.throw( - _("Stock Reservation can only be created against a {0}.").format(frappe.bold("Sales Order")) - ) - if not frappe.db.get_single_value("Stock Settings", "enable_stock_reservation"): frappe.throw( _("Please enable {0} in the {1}.").format( @@ -803,11 +798,9 @@ class StockController(AccountsController): ) ) - if not frappe.db.get_single_value("Stock Settings", "reserve_stock_on_sales_order_submission"): + if self.doctype != "Sales Order": frappe.throw( - _("Please enable {0} in the {1}.").format( - frappe.bold("Reserve Stock on Sales Order Submission"), frappe.bold("Stock Settings") - ) + _("Stock Reservation can only be created against a {0}.").format(frappe.bold("Sales Order")) ) for item in self.get("items"):