refactor: remove unnecssary vars

also remove misleading docstring
This commit is contained in:
Ankush Menat 2022-04-25 17:12:37 +05:30
parent 23cb0d684d
commit 25485edfd9

View File

@ -224,8 +224,6 @@ class PickList(Document):
item.idx = idx item.idx = idx
def update_bundle_picked_qty(self): def update_bundle_picked_qty(self):
"""Ensure that picked quantity is sufficient for fulfilling a whole number of."""
product_bundles = self._get_product_bundles() product_bundles = self._get_product_bundles()
product_bundle_qty_map = self._get_product_bundle_qty_map(product_bundles.values()) product_bundle_qty_map = self._get_product_bundle_qty_map(product_bundles.values())
@ -246,10 +244,11 @@ class PickList(Document):
for item in self.locations: for item in self.locations:
if not item.product_bundle_item: if not item.product_bundle_item:
continue continue
bundle_item_code = frappe.db.get_value( product_bundles[item.product_bundle_item] = frappe.db.get_value(
"Sales Order Item", item.product_bundle_item, "item_code" "Sales Order Item",
item.product_bundle_item,
"item_code",
) )
product_bundles[item.product_bundle_item] = bundle_item_code
return product_bundles return product_bundles
def _get_product_bundle_qty_map(self, bundles: List[str]) -> Dict[str, Dict[str, float]]: def _get_product_bundle_qty_map(self, bundles: List[str]) -> Dict[str, Dict[str, float]]: