Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: test cases

Browse Source
This commit is contained in:
Himanshu Warekar 2019-05-28 00:01:55 +05:30
parent 39490ca0c5
commit 24f8310ece
4 changed files with 34 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/support/doctype/issue_priority/test_issue_priority.py
View File

@ -15,8 +15,8 @@ def make_priorities():
insert_priority("High") insert_priority("High")
def insert_priority(name): def insert_priority(name):
frappe.get_doc({ if not frappe.db.exists("Issue Priority", name):
"doctype": "Issue Priority", frappe.get_doc({
"name": name, "doctype": "Issue Priority",
"default_priority": 1 if name == "Medium" else 0 "name": name
}).insert(ignore_permissions=True) }).insert(ignore_permissions=True)

19
erpnext/support/doctype/service_level/test_service_level.py
View File

@ -12,7 +12,14 @@ import frappe
import unittest import unittest
class TestServiceLevel(unittest.TestCase): class TestServiceLevel(unittest.TestCase):
pass
def test_service_level(self):
test_make_service_level = make_service_level()
get_make_service_level = get_service_level()
self.assertEqual(test_make_service_level.name, get_make_service_level.name)
self.assertEqual(test_make_service_level.holiday_list, get_make_service_level.holiday_list)
self.assertEqual(test_make_service_level.employee_group, get_make_service_level.employee_group)
def make_service_level(): def make_service_level():
employee_group = make_employee_group() employee_group = make_employee_group()
@ -36,6 +43,7 @@ def make_service_level():
{ {
"priority": "Medium", "priority": "Medium",
"response_time": 4, "response_time": 4,
"default_priority": 1,
"response_time_period": "Hour", "response_time_period": "Hour",
"resolution_time": 6, "resolution_time": 6,
"resolution_time_period": "Hour", "resolution_time_period": "Hour",
@ -107,6 +115,7 @@ def make_service_level():
{ {
"priority": "Medium", "priority": "Medium",
"response_time": 2, "response_time": 2,
"default_priority": 1,
"response_time_period": "Day", "response_time_period": "Day",
"resolution_time": 3, "resolution_time": 3,
"resolution_time_period": "Day", "resolution_time_period": "Day",
@ -157,16 +166,16 @@ def make_service_level():
} }
] ]
}) })
service_level_exist = frappe.db.exists("Service Level", "_Test Service Level") service_level_exist = frappe.get_doc("Service Level", "_Test Service Level")
if not service_level_exist: if not service_level_exist:
service_level.insert() service_level.insert()
return service_level.service_level return service_level
else: else:
return service_level_exist return service_level_exist
def get_service_level(): def get_service_level():
service_level = frappe.db.exists("Service Level", "_Test Service Level") return frappe.get_doc("Service Level", "_Test Service Level")
return service_level
def make_holiday_list(): def make_holiday_list():
holiday_list = frappe.db.exists("Holiday List", "__Test Holiday List") holiday_list = frappe.db.exists("Holiday List", "__Test Holiday List")

4
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@ -20,7 +20,7 @@ class ServiceLevelAgreement(Document):
if not self.ignore_start_and_end_date and self.start_date >= self.end_date: if not self.ignore_start_and_end_date and self.start_date >= self.end_date:
frappe.throw(_("Start Date of Agreement can't be greater than or equal to End Date.")) frappe.throw(_("Start Date of Agreement can't be greater than or equal to End Date."))
if not self.ignore_start_and_end_date and self.end_date < frappe.utils.today(): if not self.ignore_start_and_end_date and self.end_date < frappe.utils.getdate():
frappe.throw(_("End Date of Agreement can't be less than today.")) frappe.throw(_("End Date of Agreement can't be less than today."))
def get_service_level_agreement_priority(self, priority): def get_service_level_agreement_priority(self, priority):
@ -64,6 +64,6 @@ def get_active_service_level_agreement_for(priority, customer=None, service_leve
or_filters.append(["Service Level Agreement", "default_service_level_agreement", "=", 1]) or_filters.append(["Service Level Agreement", "default_service_level_agreement", "=", 1])
agreement = frappe.get_list("Service Level Agreement", filters=filters, or_filters=or_filters, agreement = frappe.get_list("Service Level Agreement", filters=filters, or_filters=or_filters,
fields=["name", "default_priority", "customer"], debug=True) fields=["name", "default_priority", "customer"])
return agreement[0] if agreement else None return agreement[0] if agreement else None

17
erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py
View File

@ -8,7 +8,14 @@ import unittest
from erpnext.support.doctype.service_level.test_service_level import make_service_level from erpnext.support.doctype.service_level.test_service_level import make_service_level
class TestServiceLevelAgreement(unittest.TestCase): class TestServiceLevelAgreement(unittest.TestCase):
pass
def test_service_level_agreement(self):
test_make_service_level_agreement = make_service_level_agreement()
test_get_service_level_agreement = get_service_level_agreement()
self.assertEqual(test_make_service_level_agreement.name, test_get_service_level_agreement.name)
self.assertEqual(test_make_service_level_agreement.customer, test_get_service_level_agreement.customer)
self.assertEqual(test_make_service_level_agreement.default_service_level_agreement, test_get_service_level_agreement.default_service_level_agreement)
def make_service_level_agreement(): def make_service_level_agreement():
make_service_level() make_service_level()
@ -34,6 +41,7 @@ def make_service_level_agreement():
{ {
"priority": "Medium", "priority": "Medium",
"response_time": 4, "response_time": 4,
"default_priority": 1,
"response_time_period": "Hour", "response_time_period": "Hour",
"resolution_time": 6, "resolution_time": 6,
"resolution_time_period": "Hour", "resolution_time_period": "Hour",
@ -172,13 +180,14 @@ def make_service_level_agreement():
] ]
}) })
service_level_agreement_exists = frappe.db.exists("Service Level Agreement", "SLA-_Test Service Level Agreement") service_level_agreement_exists = frappe.get_doc("Service Level Agreement", "SLA-_Test Service Level Agreement")
if not service_level_agreement_exists: if not service_level_agreement_exists:
service_level_agreement.insert(ignore_permissions=True) service_level_agreement.insert(ignore_permissions=True)
return service_level_agreement.name return service_level_agreement
else: else:
return service_level_agreement_exists return service_level_agreement_exists
def get_service_level_agreement(): def get_service_level_agreement():
service_level_agreement = frappe.db.exists("Service Level Agreement", "SLA-_Test Service Level Agreement") service_level_agreement = frappe.get_doc("Service Level Agreement", "SLA-_Test Service Level Agreement")
return service_level_agreement return service_level_agreement