Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(WooCommerce): always expect signature in webhook requests (#28367)

Browse Source
This commit is contained in:
Sagar Vora 2021-11-12 14:08:02 +05:30 committed by GitHub
parent a424310581
commit 24b048925b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/erpnext_integrations/connectors/woocommerce_connection.py
View File

@ -19,8 +19,7 @@ def verify_request():
) )
if frappe.request.data and \ if frappe.request.data and \
frappe.get_request_header("X-Wc-Webhook-Signature") and \ not sig == frappe.get_request_header("X-Wc-Webhook-Signature", "").encode():
not sig == bytes(frappe.get_request_header("X-Wc-Webhook-Signature").encode()):
frappe.throw(_("Unverified Webhook Data")) frappe.throw(_("Unverified Webhook Data"))
frappe.set_user(woocommerce_settings.creation_user) frappe.set_user(woocommerce_settings.creation_user)