From e71fa9210febc5825170774499c8c1e047f96aa8 Mon Sep 17 00:00:00 2001 From: creador Date: Sun, 14 Feb 2016 11:58:21 +0200 Subject: [PATCH 1/2] Allow reorder_level to be set to 0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For items you don’t want to keep in stock, you can set the reorder_level to 0 and define reorder_qty. If there is e.g. a sales order for that item, the projected quantity will fall below 0, which will trigger an automatic material request. --- erpnext/stock/reorder_item.py | 2 +- erpnext/stock/report/stock_projected_qty/stock_projected_qty.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/stock/reorder_item.py b/erpnext/stock/reorder_item.py index cca2456d8f..c637a12781 100644 --- a/erpnext/stock/reorder_item.py +++ b/erpnext/stock/reorder_item.py @@ -48,7 +48,7 @@ def _reorder_item(): # projected_qty will be 0 if Bin does not exist projected_qty = flt(item_warehouse_projected_qty.get(item_code, {}).get(warehouse)) - if reorder_level and projected_qty <= reorder_level: + if (reorder_level or reorder_qty) and projected_qty < reorder_level: deficiency = reorder_level - projected_qty if deficiency > reorder_qty: reorder_qty = deficiency diff --git a/erpnext/stock/report/stock_projected_qty/stock_projected_qty.py b/erpnext/stock/report/stock_projected_qty/stock_projected_qty.py index fd9ff5d585..9560709809 100644 --- a/erpnext/stock/report/stock_projected_qty/stock_projected_qty.py +++ b/erpnext/stock/report/stock_projected_qty/stock_projected_qty.py @@ -47,7 +47,7 @@ def get_data(filters): re_order_level = d.warehouse_reorder_level re_order_qty = d.warehouse_reorder_qty - shortage_qty = re_order_level - flt(bin.projected_qty) if re_order_level else 0 + shortage_qty = re_order_level - flt(bin.projected_qty) if (re_order_level or re_order_qty) else 0 data.append([item.name, item.item_name, item.description, item.item_group, item.brand, bin.warehouse, item.stock_uom, bin.actual_qty, bin.planned_qty, bin.indented_qty, bin.ordered_qty, From 38be62c7e3e668cef8b1c633cea2e310368a83d2 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 22 Feb 2016 16:24:23 +0530 Subject: [PATCH 2/2] [fix] Allow auto reorder based on reorder qty, even if reordeer level is zero --- erpnext/stock/reorder_item.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/reorder_item.py b/erpnext/stock/reorder_item.py index c637a12781..ff341c3daf 100644 --- a/erpnext/stock/reorder_item.py +++ b/erpnext/stock/reorder_item.py @@ -48,7 +48,8 @@ def _reorder_item(): # projected_qty will be 0 if Bin does not exist projected_qty = flt(item_warehouse_projected_qty.get(item_code, {}).get(warehouse)) - if (reorder_level or reorder_qty) and projected_qty < reorder_level: + if ((reorder_level and projected_qty <= reorder_level) + or (not reorder_level and reorder_qty and projected_qty < 0)): deficiency = reorder_level - projected_qty if deficiency > reorder_qty: reorder_qty = deficiency