Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: reset dr_or_cr for every reference

Browse Source 
(cherry picked from commit a59c942cd487e0440625663034760eb89171e2ef)
This commit is contained in:
Gursheen Anand 2023-11-13 18:09:49 +05:30 committed by Mergify
parent ac61abb2e4
commit 22b39ac4b4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/payment_entry/payment_entry.py
View File

@ -1054,9 +1054,9 @@ class PaymentEntry(AccountsController):
item=self, item=self,
) )
dr_or_cr = "credit" if self.payment_type == "Receive" else "debit"
for d in self.get("references"): for d in self.get("references"):
# re-defining dr_or_cr for every reference in order to avoid the last value affecting calculation of reverse
dr_or_cr = "credit" if self.payment_type == "Receive" else "debit"
cost_center = self.cost_center cost_center = self.cost_center
if d.reference_doctype == "Sales Invoice" and not cost_center: if d.reference_doctype == "Sales Invoice" and not cost_center:
cost_center = frappe.db.get_value(d.reference_doctype, d.reference_name, "cost_center") cost_center = frappe.db.get_value(d.reference_doctype, d.reference_name, "cost_center")
@ -1072,7 +1072,7 @@ class PaymentEntry(AccountsController):
against_voucher_type = d.reference_doctype against_voucher_type = d.reference_doctype
against_voucher = d.reference_name against_voucher = d.reference_name
reverse_dr_or_cr, standalone_note = 0, 0 reverse_dr_or_cr = 0
if d.reference_doctype in ["Sales Invoice", "Purchase Invoice"]: if d.reference_doctype in ["Sales Invoice", "Purchase Invoice"]:
is_return = frappe.db.get_value(d.reference_doctype, d.reference_name, "is_return") is_return = frappe.db.get_value(d.reference_doctype, d.reference_name, "is_return")
payable_party_types = get_party_types_from_account_type("Payable") payable_party_types = get_party_types_from_account_type("Payable")
@ -1098,6 +1098,7 @@ class PaymentEntry(AccountsController):
) )
gl_entries.append(gle) gl_entries.append(gle)
dr_or_cr = "credit" if self.payment_type == "Receive" else "debit"
if self.unallocated_amount: if self.unallocated_amount:
exchange_rate = self.get_exchange_rate() exchange_rate = self.get_exchange_rate()
base_unallocated_amount = self.unallocated_amount * exchange_rate base_unallocated_amount = self.unallocated_amount * exchange_rate