Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: select options should dynamically load dimensions

Browse Source 
(cherry picked from commit 1a9e091d12f9149638f3774b9def0fa80370b59b)
This commit is contained in:
ruthra kumar 2024-01-01 17:32:33 +05:30 committed by Mergify
parent 9fdf5c8091
commit 21f90011bc
1 changed files with 46 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
erpnext/accounts/report/budget_variance_report/budget_variance_report.js
View File

@ -2,7 +2,44 @@
// License: GNU General Public License v3. See license.txt // License: GNU General Public License v3. See license.txt
frappe.query_reports["Budget Variance Report"] = { frappe.query_reports["Budget Variance Report"] = {
"filters": [ "filters": get_filters(),
"formatter": function (value, row, column, data, default_formatter) {
value = default_formatter(value, row, column, data);
if (column.fieldname.includes(__("variance"))) {
if (data[column.fieldname] < 0) {
value = "<span style='color:red'>" + value + "</span>";
}
else if (data[column.fieldname] > 0) {
value = "<span style='color:green'>" + value + "</span>";
}
}
return value;
}
}
function get_filters() {
function get_dimensions() {
let result = [];
frappe.call({
method: "erpnext.accounts.doctype.accounting_dimension.accounting_dimension.get_dimensions",
args: {
'with_cost_center_and_project': true
},
async: false,
callback: function(r) {
if(!r.exc) {
result = r.message[0].map(elem => elem.document_type);
}
}
});
return result;
}
let budget_against_options = get_dimensions();
let filters = [
{ {
fieldname: "from_fiscal_year", fieldname: "from_fiscal_year",
label: __("From Fiscal Year"), label: __("From Fiscal Year"),
@ -44,9 +81,13 @@ frappe.query_reports["Budget Variance Report"] = {
fieldname: "budget_against", fieldname: "budget_against",
label: __("Budget Against"), label: __("Budget Against"),
fieldtype: "Select", fieldtype: "Select",
options: ["Cost Center", "Project"], options: budget_against_options,
default: "Cost Center", default: "Cost Center",
reqd: 1, reqd: 1,
get_data: function() {
console.log(this.options);
return ["Emacs", "Rocks"];
},
on_change: function() { on_change: function() {
frappe.query_report.set_filter_value("budget_against_filter", []); frappe.query_report.set_filter_value("budget_against_filter", []);
frappe.query_report.refresh(); frappe.query_report.refresh();
@ -71,20 +112,8 @@ frappe.query_reports["Budget Variance Report"] = {
fieldtype: "Check", fieldtype: "Check",
default: 0, default: 0,
}, },
], ]
"formatter": function (value, row, column, data, default_formatter) {
value = default_formatter(value, row, column, data);
if (column.fieldname.includes(__("variance"))) { return filters;
if (data[column.fieldname] < 0) {
value = "<span style='color:red'>" + value + "</span>";
}
else if (data[column.fieldname] > 0) {
value = "<span style='color:green'>" + value + "</span>";
}
}
return value;
}
} }