From 20721942ad3bac1776cf17e983f0b04c2fb47f78 Mon Sep 17 00:00:00 2001 From: tundebabzy Date: Tue, 17 Apr 2018 11:31:23 +0100 Subject: [PATCH] code review: use `delete from` to delete records --- erpnext/patches/v10_1/drop_old_subscription_records.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/erpnext/patches/v10_1/drop_old_subscription_records.py b/erpnext/patches/v10_1/drop_old_subscription_records.py index 11833263d1..7573f1568f 100644 --- a/erpnext/patches/v10_1/drop_old_subscription_records.py +++ b/erpnext/patches/v10_1/drop_old_subscription_records.py @@ -3,10 +3,4 @@ import frappe def execute(): - subscriptions = frappe.db.sql('SELECT name from `tabSubscription`', as_dict=True) - - for subscription in subscriptions: - doc = frappe.get_doc('Subscription', subscription['name']) - if doc.docstatus == 1: - doc.cancel() - frappe.delete_doc('Subscription', subscription['name'], force=True, ignore_permissions=True) + frappe.db.sql('DELETE from `tabSubscription`')