Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[minor] optimize item attribute validation for #5756

Browse Source
This commit is contained in:
Rushabh Mehta 2016-07-15 12:42:41 +05:30
parent b8bdfbcead
commit 20122aef79
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/controllers/item_variant.py
View File

@ -30,11 +30,11 @@ def get_variant(template, args, variant=None):
def validate_item_variant_attributes(item, args=None): def validate_item_variant_attributes(item, args=None):
if not args: if not args:
args = {d.attribute:d.attribute_value for d in item.attributes} args = {d.attribute.lower():d.attribute_value for d in item.attributes}
attribute_values = get_attribute_values() attribute_values = get_attribute_values()
numeric_attributes = frappe._dict({d.attribute: d for d numeric_attributes = frappe._dict({d.attribute.lower(): d for d
in item.attributes if d.numeric_values==1}) in item.attributes if d.numeric_values==1})
for attribute, value in args.items(): for attribute, value in args.items():