From 723b046c5bac8d8d69fbf9c0c4ae22522dde461a Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Wed, 24 Jun 2015 19:21:52 -0400 Subject: [PATCH] [fix] Use per_billed instead of per_delivered and per_received for open notification --- erpnext/change_log/v5/v5_0_28.md | 1 + erpnext/startup/notifications.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 erpnext/change_log/v5/v5_0_28.md diff --git a/erpnext/change_log/v5/v5_0_28.md b/erpnext/change_log/v5/v5_0_28.md new file mode 100644 index 0000000000..6ad54e6573 --- /dev/null +++ b/erpnext/change_log/v5/v5_0_28.md @@ -0,0 +1 @@ +- Open notification of Sales Order and Purchase Order based on whether Invoice is created against them. For eg. If a Sales Order is not Invoiced, it will be considered as open. Previously it was considered open if Delivery Note was created against Sales Order. diff --git a/erpnext/startup/notifications.py b/erpnext/startup/notifications.py index e847cfa1c9..4190f2debd 100644 --- a/erpnext/startup/notifications.py +++ b/erpnext/startup/notifications.py @@ -14,7 +14,7 @@ def get_notification_config(): "Contact": {"status": "Open"}, "Opportunity": {"status": "Open"}, "Quotation": {"docstatus": 0}, - "Sales Order": { "per_delivered": ("<", 100), "status": ("!=", "Stopped"), "docstatus": ("<", 2) }, + "Sales Order": { "per_billed": ("<", 100), "status": ("!=", "Stopped"), "docstatus": ("<", 2) }, "Journal Entry": {"docstatus": 0}, "Sales Invoice": { "outstanding_amount": (">", 0), "docstatus": ("<", 2) }, "Purchase Invoice": {"docstatus": 0}, @@ -25,7 +25,7 @@ def get_notification_config(): "Delivery Note": {"docstatus": 0}, "Stock Entry": {"docstatus": 0}, "Material Request": {"docstatus": 0}, - "Purchase Order": { "per_received": ("<", 100), "status": ("!=", "Stopped"), "docstatus": ("<", 2) }, + "Purchase Order": { "per_billed": ("<", 100), "status": ("!=", "Stopped"), "docstatus": ("<", 2) }, "Production Order": { "status": "In Process" }, "BOM": {"docstatus": 0}, "Timesheet": {"docstatus": 0},