refactor: Change Filter Fields table fieldtype to Autocomplete

- Remove dynamic js fieldtype change to `Select`

erpnext/e_commerce/doctype/e_commerce_settings/e_commerce_settings.js

@@ -27,13 +27,12 @@ frappe.ui.form.on("E Commerce Settings", {
 		frappe.model.with_doctype("Website Item", () => {
 			const web_item_meta = frappe.get_meta('Website Item');
 
-			const valid_fields = web_item_meta.fields.filter(
+			const valid_fields = web_item_meta.fields.filter(df =>
-				df => ["Link", "Table MultiSelect"].includes(df.fieldtype) && !df.hidden
+				["Link", "Table MultiSelect"].includes(df.fieldtype) && !df.hidden
-			).map(df => ({ label: df.label, value: df.fieldname }));
+			).map(df =>
-
+				({ label: df.label, value: df.fieldname })
-			frm.get_field("filter_fields").grid.update_docfield_property(
-				'fieldname', 'fieldtype', 'Select'
 			);
+
 			frm.get_field("filter_fields").grid.update_docfield_property(
 				'fieldname', 'options', valid_fields
 			);

erpnext/portal/doctype/website_filter_field/website_filter_field.json

@@ -1,76 +1,31 @@
 {
- "allow_copy": 0, 
+ "actions": [],
- "allow_events_in_timeline": 0, 
+ "creation": "2018-12-31 17:06:08.716134",
- "allow_guest_to_view": 0, 
+ "doctype": "DocType",
- "allow_import": 0, 
+ "editable_grid": 1,
- "allow_rename": 0, 
+ "engine": "InnoDB",
- "beta": 0, 
+ "field_order": [
- "creation": "2018-12-31 17:06:08.716134", 
+  "fieldname"
- "custom": 0, 
+ ],
- "docstatus": 0, 
- "doctype": "DocType", 
- "document_type": "", 
- "editable_grid": 1, 
- "engine": "InnoDB", 
  "fields": [
   {
-   "allow_bulk_edit": 0, 
+   "fieldname": "fieldname",
-   "allow_in_quick_entry": 0, 
+   "fieldtype": "Autocomplete",
-   "allow_on_submit": 0, 
+   "in_list_view": 1,
-   "bold": 0, 
+   "label": "Fieldname"
-   "collapsible": 0, 
-   "columns": 0, 
-   "fieldname": "fieldname", 
-   "fieldtype": "Data", 
-   "hidden": 0, 
-   "ignore_user_permissions": 0, 
-   "ignore_xss_filter": 0, 
-   "in_filter": 0, 
-   "in_global_search": 0, 
-   "in_list_view": 1, 
-   "in_standard_filter": 0, 
-   "label": "Fieldname", 
-   "length": 0, 
-   "no_copy": 0, 
-   "options": "", 
-   "permlevel": 0, 
-   "precision": "", 
-   "print_hide": 0, 
-   "print_hide_if_no_value": 0, 
-   "read_only": 0, 
-   "remember_last_selected_value": 0, 
-   "report_hide": 0, 
-   "reqd": 0, 
-   "search_index": 0, 
-   "set_only_once": 0, 
-   "translatable": 0, 
-   "unique": 0
   }
- ], 
+ ],
- "has_web_view": 0, 
+ "istable": 1,
- "hide_heading": 0, 
+ "links": [],
- "hide_toolbar": 0, 
+ "modified": "2022-04-18 18:55:17.835666",
- "idx": 0, 
+ "modified_by": "Administrator",
- "image_view": 0, 
+ "module": "Portal",
- "in_create": 0, 
+ "name": "Website Filter Field",
- "is_submittable": 0, 
+ "owner": "Administrator",
- "issingle": 0, 
+ "permissions": [],
- "istable": 1, 
+ "quick_entry": 1,
- "max_attachments": 0, 
+ "sort_field": "modified",
- "modified": "2019-01-01 18:26:11.550380", 
+ "sort_order": "DESC",
- "modified_by": "Administrator", 
+ "states": [],
- "module": "Portal", 
+ "track_changes": 1
- "name": "Website Filter Field", 
- "name_case": "", 
- "owner": "Administrator", 
- "permissions": [], 
- "quick_entry": 1, 
- "read_only": 0, 
- "read_only_onload": 0, 
- "show_name_in_global_search": 0, 
- "sort_field": "modified", 
- "sort_order": "DESC", 
- "track_changes": 1, 
- "track_seen": 0, 
- "track_views": 0
 }

erpnext/setup/doctype/item_group/item_group.js

@@ -75,13 +75,12 @@ frappe.ui.form.on("Item Group", {
 		frappe.model.with_doctype('Website Item', () => {
 			const web_item_meta = frappe.get_meta('Website Item');
 
-			const valid_fields = web_item_meta.fields.filter(
+			const valid_fields = web_item_meta.fields.filter(df =>
-				df => ['Link', 'Table MultiSelect'].includes(df.fieldtype) && !df.hidden
+				['Link', 'Table MultiSelect'].includes(df.fieldtype) && !df.hidden
-			).map(df => ({ label: df.label, value: df.fieldname }));
+			).map(df =>
-
+				({ label: df.label, value: df.fieldname })
-			frm.get_field("filter_fields").grid.update_docfield_property(
-				'fieldname', 'fieldtype', 'Select'
 			);
+
 			frm.get_field("filter_fields").grid.update_docfield_property(
 				'fieldname', 'options', valid_fields
 			);