From 1e4cfb4bf5ae0575dcae51fe36432c5fd5771585 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Thu, 15 Mar 2018 12:27:24 +0530 Subject: [PATCH] Fixes in setting po nos manually in sales invoice --- erpnext/controllers/selling_controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py index ad32ab5958..606cc90866 100644 --- a/erpnext/controllers/selling_controller.py +++ b/erpnext/controllers/selling_controller.py @@ -332,7 +332,7 @@ class SellingController(StockController): def set_po_nos(self): if self.doctype in ("Delivery Note", "Sales Invoice"): ref_fieldname = "against_sales_order" if self.doctype == "Delivery Note" else "sales_order" - sales_orders = list(set([d.get(ref_fieldname) for d in self.items])) + sales_orders = list(set([d.get(ref_fieldname) for d in self.items if d.get(ref_fieldname)])) if sales_orders: po_nos = frappe.get_all('Sales Order', 'po_no', filters = {'name': ('in', sales_orders)}) self.po_no = ', '.join(list(set([d.po_no for d in po_nos if d.po_no])))