From 25ef4ff37329e5313c9415cfdfb61e97bbd9a806 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Tue, 20 Oct 2015 18:34:21 +0530 Subject: [PATCH 1/2] [fix] variant selector display --- erpnext/patches/v6_4/make_image_thumbnail.py | 4 +- erpnext/templates/generators/item.html | 40 ++++++++++---------- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/erpnext/patches/v6_4/make_image_thumbnail.py b/erpnext/patches/v6_4/make_image_thumbnail.py index 36bdcfc6d4..702148a8f6 100644 --- a/erpnext/patches/v6_4/make_image_thumbnail.py +++ b/erpnext/patches/v6_4/make_image_thumbnail.py @@ -3,8 +3,8 @@ import frappe def execute(): frappe.reload_doctype("File") frappe.reload_doctype("Item") - for item in frappe.get_all("Item", fields=("name", "website_image")): - if item.website_image: + for item in frappe.get_all("Item", fields=("name", "website_image", "thumbnail")): + if item.website_image and not item.thumbnail: item_doc = frappe.get_doc("Item", item.name) try: item_doc.make_thumbnail() diff --git a/erpnext/templates/generators/item.html b/erpnext/templates/generators/item.html index ccb992b804..4bd521d5a7 100644 --- a/erpnext/templates/generators/item.html +++ b/erpnext/templates/generators/item.html @@ -26,29 +26,31 @@

{{ _("Item Code") }}: {{ name }}


+
+ {% if has_variants %} + {% for d in attributes %} +
+
{{ _(d.attribute) }}
+ +
+ {% endfor %} + {% endif %} +
+

- {% if has_variants %} - {% for d in attributes %} -
-
{{ _(d.attribute) }}
- -
- {% endfor %} - {% endif %} -
From 2678135f5eba6459aa911cd626d4b0f161aed247 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Tue, 20 Oct 2015 19:05:49 +0600 Subject: [PATCH 2/2] bumped to version 6.5.3 --- erpnext/__version__.py | 2 +- erpnext/hooks.py | 2 +- setup.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/__version__.py b/erpnext/__version__.py index 68def1b955..75df8d1162 100644 --- a/erpnext/__version__.py +++ b/erpnext/__version__.py @@ -1,2 +1,2 @@ from __future__ import unicode_literals -__version__ = '6.5.2' +__version__ = '6.5.3' diff --git a/erpnext/hooks.py b/erpnext/hooks.py index defbfbc9b2..d091b44bf8 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -29,7 +29,7 @@ blogs. """ app_icon = "icon-th" app_color = "#e74c3c" -app_version = "6.5.2" +app_version = "6.5.3" github_link = "https://github.com/frappe/erpnext" error_report_email = "support@erpnext.com" diff --git a/setup.py b/setup.py index 6af4e323b7..867301cc0a 100644 --- a/setup.py +++ b/setup.py @@ -1,6 +1,6 @@ from setuptools import setup, find_packages -version = "6.5.2" +version = "6.5.3" with open("requirements.txt", "r") as f: install_requires = f.readlines()