Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Refactor/Cleanup] Cleaned debug print statement

Browse Source 
Refactored code to use format() instead of string formatting using %s
This commit is contained in:
shreyas 2016-01-29 12:39:58 +05:30 committed by Anand Doshi
parent c761f1b0a1
commit 1a943151d7
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/selling/report/sales_person_target_variance_item_group_wise/sales_person_target_variance_item_group_wise.py
View File

@ -111,7 +111,6 @@ def get_achieved_details(filters, sales_person, item_groups):
item_actual_details = {}
for d in item_details:
item_group = item_groups[d.item_code]
print item_group
item_actual_details.setdefault(item_group, frappe._dict()).setdefault(d.month_name,\
frappe._dict({
"quantity" : 0,

8
erpnext/selling/report/sales_person_wise_transaction_summary/sales_person_wise_transaction_summary.py
View File

@ -13,9 +13,9 @@ def execute(filters=None):
entries = get_entries(filters)
item_details = get_item_details()
data = []
total_contribution_amoount = 0
total_contribution_amount = 0
for d in entries:
total_contribution_amoount += flt(d.contribution_amt)
total_contribution_amount += flt(d.contribution_amt)
data.append([
d.name, d.customer, d.territory, d.posting_date, d.item_code,
@ -26,7 +26,7 @@ def execute(filters=None):
if data:
total_row = [""]*len(data[0])
total_row[0] = _("Total")
total_row[-1] = total_contribution_amoount
total_row[-1] = total_contribution_amount
data.append(total_row)
return columns, data
@ -71,7 +71,7 @@ def get_conditions(filters, date_field):
if filters.get("sales_person"):
lft, rgt = frappe.get_value("Sales Person", filters.get("sales_person"), ["lft", "rgt"])
conditions.append("exists(select name from `tabSales Person` where lft >= %s and rgt <= %s and name=st.sales_person)" % (lft, rgt))
conditions.append("exists(select name from `tabSales Person` where lft >= {0} and rgt <= {1} and name=st.sales_person)".format(lft, rgt))
if filters.get("from_date"):
conditions.append("dt.{0}>=%s".format(date_field))