Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(tally): Ignore unhandled vouchers silently (#18430)

Browse Source 
Vouchers that affect inventory entries but are not of type
Sales, Purchase, Credit Note, Debit Note are not handled.

Custom Vouchers are also not handled.
This commit is contained in:
Aditya Hase 2019-07-22 11:18:11 +05:30 committed by Nabin Hait
parent 16a0458e29
commit 195465cdd9
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/erpnext_integrations/doctype/tally_migration/tally_migration.py
View File

@ -296,7 +296,9 @@ class TallyMigration(Document):
else: else:
function = voucher_to_journal_entry function = voucher_to_journal_entry
try: try:
vouchers.append(function(voucher)) processed_voucher = function(voucher)
if processed_voucher:
vouchers.append(processed_voucher)
except: except:
self.log(voucher) self.log(voucher)
return vouchers return vouchers
@ -342,6 +344,10 @@ class TallyMigration(Document):
account_field = "credit_to" account_field = "credit_to"
account_name = encode_company_abbr(self.tally_creditors_account, self.erpnext_company) account_name = encode_company_abbr(self.tally_creditors_account, self.erpnext_company)
price_list_field = "buying_price_list" price_list_field = "buying_price_list"
else:
# Do not handle vouchers other than "Purchase", "Debit Note", "Sales" and "Credit Note"
# Do not handle Custom Vouchers either
return
invoice = { invoice = {
"doctype": doctype, "doctype": doctype,