Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Reverse GL entries only for submitted Dunnings

Browse Source
This commit is contained in:
marination 2023-07-20 20:54:43 +05:30
parent aeae8d646a
commit 17ff395f9a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/patches/v14_0/single_to_multi_dunning.py
View File

@ -7,6 +7,7 @@ def execute():
frappe.reload_doc("accounts", "doctype", "overdue_payment") frappe.reload_doc("accounts", "doctype", "overdue_payment")
frappe.reload_doc("accounts", "doctype", "dunning") frappe.reload_doc("accounts", "doctype", "dunning")
# Migrate schema of all uncancelled dunnings
filters = {"docstatus": ("!=", 2)} filters = {"docstatus": ("!=", 2)}
can_edit_accounts_after = get_accounts_closing_date() can_edit_accounts_after = get_accounts_closing_date()
@ -49,7 +50,8 @@ def execute():
dunning.flags.ignore_validate_update_after_submit = True dunning.flags.ignore_validate_update_after_submit = True
dunning.save() dunning.save()
if dunning.status != "Resolved": # Reverse entries only if dunning is submitted and not resolved
if dunning.docstatus == 1 and dunning.status != "Resolved":
# With the new logic, dunning amount gets recorded as additional income # With the new logic, dunning amount gets recorded as additional income
# at time of payment. We don't want to record the dunning amount twice, # at time of payment. We don't want to record the dunning amount twice,
# so we reverse previous GL Entries that recorded the dunning amount at # so we reverse previous GL Entries that recorded the dunning amount at