From 16c297c2ecbc9a174e90597756cf46170bbd7c4a Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Tue, 5 Dec 2023 18:06:14 +0530 Subject: [PATCH] feat: add `Valuation Method` column in `Stock Ledger Variance` report --- .../stock_ledger_variance.py | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/erpnext/stock/report/stock_ledger_variance/stock_ledger_variance.py b/erpnext/stock/report/stock_ledger_variance/stock_ledger_variance.py index 194f0ca637..189a90aa47 100644 --- a/erpnext/stock/report/stock_ledger_variance/stock_ledger_variance.py +++ b/erpnext/stock/report/stock_ledger_variance/stock_ledger_variance.py @@ -55,6 +55,11 @@ def get_columns(): "label": _("Warehouse"), "options": "Warehouse", }, + { + "fieldname": "valuation_method", + "fieldtype": "Data", + "label": _("Valuation Method"), + }, { "fieldname": "voucher_type", "fieldtype": "Link", @@ -210,7 +215,14 @@ def get_data(filters=None): if has_difference( row, precision, filters.difference_in, item_warehouse.valuation_method or valuation_method ): - data.append(add_item_warehouse_details(row, item_warehouse)) + row.update( + { + "item_code": item_warehouse.item_code, + "warehouse": item_warehouse.warehouse, + "valuation_method": item_warehouse.valuation_method or valuation_method, + } + ) + data.append(row) break return data @@ -276,15 +288,3 @@ def has_difference(row, precision, difference_in, valuation_method): qty_diff or value_diff or valuation_diff ): return True - - -def add_item_warehouse_details(row, item_warehouse): - row.update( - { - "item_code": item_warehouse.item_code, - "warehouse": item_warehouse.warehouse, - "valuation_method": item_warehouse.valuation_method, - } - ) - - return row