From e7c7a0e6487ce659428e5f1aefbc8c8af13a0b16 Mon Sep 17 00:00:00 2001 From: Mangesh-Khairnar Date: Mon, 2 Sep 2019 15:59:44 +0530 Subject: [PATCH] fix: loan application (#18882) * fix: loan application * Update loan_application.py --- erpnext/hr/doctype/loan_application/loan_application.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/loan_application/loan_application.py b/erpnext/hr/doctype/loan_application/loan_application.py index 28d9c43f8e..582bf48bf0 100644 --- a/erpnext/hr/doctype/loan_application/loan_application.py +++ b/erpnext/hr/doctype/loan_application/loan_application.py @@ -30,7 +30,7 @@ class LoanApplication(Document): monthly_interest_rate = flt(self.rate_of_interest) / (12 *100) if monthly_interest_rate: min_repayment_amount = self.loan_amount*monthly_interest_rate - if self.repayment_amount - min_repayment_amount <= 0: + if (self.repayment_amount - min_repayment_amount) <= 0: frappe.throw(_("Repayment Amount must be greater than " \ + str(flt(min_repayment_amount, 2)))) self.repayment_periods = math.ceil((math.log(self.repayment_amount) - @@ -58,10 +58,13 @@ def make_loan(source_name, target_doc = None): doclist = get_mapped_doc("Loan Application", source_name, { "Loan Application": { "doctype": "Loan", + "field_map": { + "repayment_amount": "monthly_repayment_amount" + }, "validation": { "docstatus": ["=", 1] } } }, target_doc) - return doclist \ No newline at end of file + return doclist