Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: get_valuation_rate in bom.py must always return float & goto Item master if no bins

Browse Source
This commit is contained in:
marination 2022-06-06 17:12:43 +05:30
parent 934db57fdd
commit 15101190a6
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/manufacturing/doctype/bom/bom.py
View File

@ -961,11 +961,8 @@ def get_valuation_rate(args):
valuation_rate = item_valuation.get("valuation_rate")
if valuation_rate is None:
# Explicit null value check. If null, Bins don't exist, neither does SLE
return valuation_rate
if valuation_rate <= 0:
if (valuation_rate is not None) and valuation_rate <= 0:
# Explicit null value check. If None, Bins don't exist, neither does SLE
last_valuation_rate = frappe.db.sql(
"""select valuation_rate
from `tabStock Ledger Entry`