From 146f17bf57483771b30e9d0e0af76a12246e6645 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Sat, 3 Mar 2012 15:01:41 +0530 Subject: [PATCH] fix in delivery note submission - error caused due to default packed qty --- erpnext/stock/doctype/delivery_note/delivery_note.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.py b/erpnext/stock/doctype/delivery_note/delivery_note.py index e8af7ef39f..99f688fac4 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/delivery_note.py @@ -351,16 +351,17 @@ class DocType(TransactionBase): """ Validate that if packed qty exists, it should be equal to qty """ - if not any([d.fields.get('packed_qty') for d in self.doclist]): + if not any([flt(d.fields.get('packed_qty')) for d in self.doclist if + d.doctype=='Delivery Note Detail']): return packing_error_list = [] for d in self.doclist: if d.doctype != 'Delivery Note Detail': continue - if d.fields.get('qty') != d.fields.get('packed_qty'): + if flt(d.fields.get('qty')) != flt(d.fields.get('packed_qty')): packing_error_list.append([ d.fields.get('item_code', ''), - d.fields.get('qty', ''), - d.fields.get('packed_qty', '') + d.fields.get('qty', 0), + d.fields.get('packed_qty', 0) ]) if packing_error_list: from webnotes.utils import cstr