Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(payments): Only check for Draft or Submitted paymentswhile cancelling payment requests

Browse Source
This commit is contained in:
Rohan Bansal 2019-02-21 15:32:52 +05:30
parent 463a3cf8cf
commit 143973166f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/doctype/payment_request/payment_request.py
View File

@ -214,9 +214,11 @@ class PaymentRequest(Document):
def check_if_payment_entry_exists(self):
if self.status == "Paid":
payment_entry = frappe.db.sql_list("""select parent from `tabPayment Entry Reference`
where reference_name=%s""", self.reference_name)
if payment_entry:
payment_entry = frappe.get_all("Payment Entry Reference",
filters={"reference_name": self.reference_name, "docstatus": ["<", 2]},
fields=["distinct(parent)"])
if any(payment_entry):
frappe.throw(_("Payment Entry already exists"), title=_('Error'))
def make_communication_entry(self):