Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Handle loan type naming collisions

Browse Source
This commit is contained in:
Deepesh Garg 2020-11-11 11:07:17 +05:30
parent 73bde45bc5
commit 13d1dda74b
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/patches/v13_0/update_old_loans.py
View File

@ -51,7 +51,7 @@ def execute():
if not loan_type_name: if not loan_type_name:
loan_type_name = loan.loan_type + " - " + ''.join([c[0] for c in loan.company.split()]).upper() loan_type_name = loan.loan_type + " - " + ''.join([c[0] for c in loan.company.split()]).upper()
create_loan_type(loan, loan_type_name, penalty_account) loan_type_name = create_loan_type(loan, loan_type_name, penalty_account)
# update loan type in loan # update loan type in loan
frappe.db.sql("UPDATE `tabLoan` set loan_type = %s where name = %s", (loan_type_name, frappe.db.sql("UPDATE `tabLoan` set loan_type = %s where name = %s", (loan_type_name,
@ -111,6 +111,10 @@ def execute():
jv.cancel() jv.cancel()
def create_loan_type(loan, loan_type_name, penalty_account): def create_loan_type(loan, loan_type_name, penalty_account):
if frappe.db.get_value('Loan Type', loan_type_name):
loan_type_name = loan_type_name + '-1'
loan_type_doc = frappe.new_doc('Loan Type') loan_type_doc = frappe.new_doc('Loan Type')
loan_type_doc.loan_name = loan_type_name loan_type_doc.loan_name = loan_type_name
loan_type_doc.is_term_loan = 1 loan_type_doc.is_term_loan = 1