From 12aa35aa434422a13dc253f761dc56985afc9ee8 Mon Sep 17 00:00:00 2001 From: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com> Date: Mon, 2 Mar 2020 19:10:29 +0530 Subject: [PATCH] fix: Label and UX fixes in AP/AP reports (#20803) --- .../report/accounts_payable/accounts_payable.js | 14 +++++++------- .../accounts_payable_summary.js | 14 +++++++------- .../accounts_receivable/accounts_receivable.js | 16 ++++++++-------- .../accounts_receivable_summary.js | 14 +++++++------- 4 files changed, 29 insertions(+), 29 deletions(-) diff --git a/erpnext/accounts/report/accounts_payable/accounts_payable.js b/erpnext/accounts/report/accounts_payable/accounts_payable.js index df700ec9d3..4e09f99ae3 100644 --- a/erpnext/accounts/report/accounts_payable/accounts_payable.js +++ b/erpnext/accounts/report/accounts_payable/accounts_payable.js @@ -11,18 +11,18 @@ frappe.query_reports["Accounts Payable"] = { "reqd": 1, "default": frappe.defaults.get_user_default("Company") }, + { + "fieldname":"report_date", + "label": __("Posting Date"), + "fieldtype": "Date", + "default": frappe.datetime.get_today() + }, { "fieldname":"ageing_based_on", "label": __("Ageing Based On"), "fieldtype": "Select", "options": 'Posting Date\nDue Date\nSupplier Invoice Date', - "default": "Posting Date" - }, - { - "fieldname":"report_date", - "label": __("As on Date"), - "fieldtype": "Date", - "default": frappe.datetime.get_today() + "default": "Due Date" }, { "fieldname":"range1", diff --git a/erpnext/accounts/report/accounts_payable_summary/accounts_payable_summary.js b/erpnext/accounts/report/accounts_payable_summary/accounts_payable_summary.js index 4a9f1b0dc4..d5f18b0982 100644 --- a/erpnext/accounts/report/accounts_payable_summary/accounts_payable_summary.js +++ b/erpnext/accounts/report/accounts_payable_summary/accounts_payable_summary.js @@ -10,18 +10,18 @@ frappe.query_reports["Accounts Payable Summary"] = { "options": "Company", "default": frappe.defaults.get_user_default("Company") }, + { + "fieldname":"report_date", + "label": __("Posting Date"), + "fieldtype": "Date", + "default": frappe.datetime.get_today() + }, { "fieldname":"ageing_based_on", "label": __("Ageing Based On"), "fieldtype": "Select", "options": 'Posting Date\nDue Date', - "default": "Posting Date" - }, - { - "fieldname":"report_date", - "label": __("Date"), - "fieldtype": "Date", - "default": frappe.datetime.get_today() + "default": "Due Date" }, { "fieldname":"range1", diff --git a/erpnext/accounts/report/accounts_receivable/accounts_receivable.js b/erpnext/accounts/report/accounts_receivable/accounts_receivable.js index 5d0154f597..6208eb6946 100644 --- a/erpnext/accounts/report/accounts_receivable/accounts_receivable.js +++ b/erpnext/accounts/report/accounts_receivable/accounts_receivable.js @@ -11,18 +11,18 @@ frappe.query_reports["Accounts Receivable"] = { "reqd": 1, "default": frappe.defaults.get_user_default("Company") }, + { + "fieldname":"report_date", + "label": __("Posting Date"), + "fieldtype": "Date", + "default": frappe.datetime.get_today() + }, { "fieldname":"ageing_based_on", "label": __("Ageing Based On"), "fieldtype": "Select", "options": 'Posting Date\nDue Date', - "default": "Posting Date" - }, - { - "fieldname":"report_date", - "label": __("As on Date"), - "fieldtype": "Date", - "default": frappe.datetime.get_today() + "default": "Due Date" }, { "fieldname":"range1", @@ -148,7 +148,7 @@ frappe.query_reports["Accounts Receivable"] = { }, { "fieldname":"show_delivery_notes", - "label": __("Show Delivery Notes"), + "label": __("Show Linked Delivery Notes"), "fieldtype": "Check", }, { diff --git a/erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.js b/erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.js index d54824b685..b316f108d0 100644 --- a/erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.js +++ b/erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.js @@ -10,18 +10,18 @@ frappe.query_reports["Accounts Receivable Summary"] = { "options": "Company", "default": frappe.defaults.get_user_default("Company") }, + { + "fieldname":"report_date", + "label": __("Posting Date"), + "fieldtype": "Date", + "default": frappe.datetime.get_today() + }, { "fieldname":"ageing_based_on", "label": __("Ageing Based On"), "fieldtype": "Select", "options": 'Posting Date\nDue Date', - "default": "Posting Date" - }, - { - "fieldname":"report_date", - "label": __("Date"), - "fieldtype": "Date", - "default": frappe.datetime.get_today() + "default": "Due Date" }, { "fieldname":"range1",