Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: custom cash flow mapper doesn't show any data

Browse Source
This commit is contained in:
Saqib Ansari 2022-03-17 11:56:10 +05:30
parent e9e2679dff
commit 119273e633
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/accounts/report/cash_flow/custom_cash_flow.py
View File

@ -30,12 +30,12 @@ def get_mappers_from_db():
def get_accounts_in_mappers(mapping_names): def get_accounts_in_mappers(mapping_names):
return frappe.db.sql(''' return frappe.db.sql('''
select cfma.name, cfm.label, cfm.is_working_capital, cfm.is_income_tax_liability, select cfma.name, cfm.label, cfm.is_working_capital, cfm.is_income_tax_liability,
cfm.is_income_tax_expense, cfm.is_finance_cost, cfm.is_finance_cost_adjustment cfm.is_income_tax_expense, cfm.is_finance_cost, cfm.is_finance_cost_adjustment, cfma.account
from `tabCash Flow Mapping Accounts` cfma from `tabCash Flow Mapping Accounts` cfma
join `tabCash Flow Mapping` cfm on cfma.parent=cfm.name join `tabCash Flow Mapping` cfm on cfma.parent=cfm.name
where cfma.parent in (%s) where cfma.parent in (%s)
order by cfm.is_working_capital order by cfm.is_working_capital
''', (', '.join('"%s"' % d for d in mapping_names))) ''', (', '.join('%s' % d for d in mapping_names)))
def setup_mappers(mappers): def setup_mappers(mappers):
@ -57,31 +57,31 @@ def setup_mappers(mappers):
account_types = [ account_types = [
dict( dict(
name=account[0], label=account[1], is_working_capital=account[2], name=account[0], account_name=account[7], label=account[1], is_working_capital=account[2],
is_income_tax_liability=account[3], is_income_tax_expense=account[4] is_income_tax_liability=account[3], is_income_tax_expense=account[4]
) for account in accounts if not account[3]] ) for account in accounts if not account[3]]
finance_costs_adjustments = [ finance_costs_adjustments = [
dict( dict(
name=account[0], label=account[1], is_finance_cost=account[5], name=account[0], account_name=account[7], label=account[1], is_finance_cost=account[5],
is_finance_cost_adjustment=account[6] is_finance_cost_adjustment=account[6]
) for account in accounts if account[6]] ) for account in accounts if account[6]]
tax_liabilities = [ tax_liabilities = [
dict( dict(
name=account[0], label=account[1], is_income_tax_liability=account[3], name=account[0], account_name=account[7], label=account[1], is_income_tax_liability=account[3],
is_income_tax_expense=account[4] is_income_tax_expense=account[4]
) for account in accounts if account[3]] ) for account in accounts if account[3]]
tax_expenses = [ tax_expenses = [
dict( dict(
name=account[0], label=account[1], is_income_tax_liability=account[3], name=account[0], account_name=account[7], label=account[1], is_income_tax_liability=account[3],
is_income_tax_expense=account[4] is_income_tax_expense=account[4]
) for account in accounts if account[4]] ) for account in accounts if account[4]]
finance_costs = [ finance_costs = [
dict( dict(
name=account[0], label=account[1], is_finance_cost=account[5]) name=account[0], account_name=account[7], label=account[1], is_finance_cost=account[5])
for account in accounts if account[5]] for account in accounts if account[5]]
account_types_labels = sorted( account_types_labels = sorted(
@ -124,27 +124,27 @@ def setup_mappers(mappers):
) )
for label in account_types_labels: for label in account_types_labels:
names = [d['name'] for d in account_types if d['label'] == label[0]] names = [d['account_name'] for d in account_types if d['label'] == label[0]]
m = dict(label=label[0], names=names, is_working_capital=label[1]) m = dict(label=label[0], names=names, is_working_capital=label[1])
mapping['account_types'].append(m) mapping['account_types'].append(m)
for label in fc_adjustment_labels: for label in fc_adjustment_labels:
names = [d['name'] for d in finance_costs_adjustments if d['label'] == label[0]] names = [d['account_name'] for d in finance_costs_adjustments if d['label'] == label[0]]
m = dict(label=label[0], names=names) m = dict(label=label[0], names=names)
mapping['finance_costs_adjustments'].append(m) mapping['finance_costs_adjustments'].append(m)
for label in unique_liability_labels: for label in unique_liability_labels:
names = [d['name'] for d in tax_liabilities if d['label'] == label[0]] names = [d['account_name'] for d in tax_liabilities if d['label'] == label[0]]
m = dict(label=label[0], names=names, tax_liability=label[1], tax_expense=label[2]) m = dict(label=label[0], names=names, tax_liability=label[1], tax_expense=label[2])
mapping['tax_liabilities'].append(m) mapping['tax_liabilities'].append(m)
for label in unique_expense_labels: for label in unique_expense_labels:
names = [d['name'] for d in tax_expenses if d['label'] == label[0]] names = [d['account_name'] for d in tax_expenses if d['label'] == label[0]]
m = dict(label=label[0], names=names, tax_liability=label[1], tax_expense=label[2]) m = dict(label=label[0], names=names, tax_liability=label[1], tax_expense=label[2])
mapping['tax_expenses'].append(m) mapping['tax_expenses'].append(m)
for label in unique_finance_costs_labels: for label in unique_finance_costs_labels:
names = [d['name'] for d in finance_costs if d['label'] == label[0]] names = [d['account_name'] for d in finance_costs if d['label'] == label[0]]
m = dict(label=label[0], names=names, is_finance_cost=label[1]) m = dict(label=label[0], names=names, is_finance_cost=label[1])
mapping['finance_costs'].append(m) mapping['finance_costs'].append(m)
@ -378,7 +378,7 @@ def _get_account_type_based_data(filters, account_names, period_list, accumulate
total = 0 total = 0
for period in period_list: for period in period_list:
start_date = get_start_date(period, accumulated_values, company) start_date = get_start_date(period, accumulated_values, company)
accounts = ', '.join('"%s"' % d for d in account_names) accounts = ', '.join('%s' % d for d in account_names)
if opening_balances: if opening_balances:
date_info = dict(date=start_date) date_info = dict(date=start_date)