Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: batches not coming correctly in the batch selector

Browse Source
This commit is contained in:
Rohit Waghchaure 2024-01-14 23:23:55 +05:30
parent 6401908f41
commit 114f2b4326
1 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
erpnext/controllers/queries.py
View File

@ -421,23 +421,14 @@ def get_batch_no(doctype, txt, searchfield, start, page_len, filters):
meta = frappe.get_meta(doctype, cached=True) meta = frappe.get_meta(doctype, cached=True)
searchfields = meta.get_search_fields() searchfields = meta.get_search_fields()
query = get_batches_from_stock_ledger_entries(searchfields, txt, filters) batches = get_batches_from_stock_ledger_entries(searchfields, txt, filters, start, page_len)
bundle_query = get_batches_from_serial_and_batch_bundle(searchfields, txt, filters) batches.extend(
get_batches_from_serial_and_batch_bundle(searchfields, txt, filters, start, page_len)
data = (
frappe.qb.from_((query) + (bundle_query))
.select("batch_no", "qty", "manufacturing_date", "expiry_date")
.offset(start)
.limit(page_len)
) )
for field in searchfields: filtered_batches = get_filterd_batches(batches)
data = data.select(field)
data = data.run() return filtered_batches
data = get_filterd_batches(data)
return data
def get_filterd_batches(data): def get_filterd_batches(data):
@ -457,7 +448,7 @@ def get_filterd_batches(data):
return filterd_batch return filterd_batch
def get_batches_from_stock_ledger_entries(searchfields, txt, filters): def get_batches_from_stock_ledger_entries(searchfields, txt, filters, start=0, page_len=100):
stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry") stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry")
batch_table = frappe.qb.DocType("Batch") batch_table = frappe.qb.DocType("Batch")
@ -479,6 +470,8 @@ def get_batches_from_stock_ledger_entries(searchfields, txt, filters):
& (stock_ledger_entry.batch_no.isnotnull()) & (stock_ledger_entry.batch_no.isnotnull())
) )
.groupby(stock_ledger_entry.batch_no, stock_ledger_entry.warehouse) .groupby(stock_ledger_entry.batch_no, stock_ledger_entry.warehouse)
.offset(start)
.limit(page_len)
) )
query = query.select( query = query.select(
@ -493,16 +486,16 @@ def get_batches_from_stock_ledger_entries(searchfields, txt, filters):
query = query.select(batch_table[field]) query = query.select(batch_table[field])
if txt: if txt:
txt_condition = batch_table.name.like(txt) txt_condition = batch_table.name.like("%{0}%".format(txt))
for field in searchfields + ["name"]: for field in searchfields + ["name"]:
txt_condition |= batch_table[field].like(txt) txt_condition |= batch_table[field].like("%{0}%".format(txt))
query = query.where(txt_condition) query = query.where(txt_condition)
return query return query.run(as_list=1) or []
def get_batches_from_serial_and_batch_bundle(searchfields, txt, filters): def get_batches_from_serial_and_batch_bundle(searchfields, txt, filters, start=0, page_len=100):
bundle = frappe.qb.DocType("Serial and Batch Entry") bundle = frappe.qb.DocType("Serial and Batch Entry")
stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry") stock_ledger_entry = frappe.qb.DocType("Stock Ledger Entry")
batch_table = frappe.qb.DocType("Batch") batch_table = frappe.qb.DocType("Batch")
@ -527,6 +520,8 @@ def get_batches_from_serial_and_batch_bundle(searchfields, txt, filters):
& (stock_ledger_entry.serial_and_batch_bundle.isnotnull()) & (stock_ledger_entry.serial_and_batch_bundle.isnotnull())
) )
.groupby(bundle.batch_no, bundle.warehouse) .groupby(bundle.batch_no, bundle.warehouse)
.offset(start)
.limit(page_len)
) )
bundle_query = bundle_query.select( bundle_query = bundle_query.select(
@ -541,13 +536,13 @@ def get_batches_from_serial_and_batch_bundle(searchfields, txt, filters):
bundle_query = bundle_query.select(batch_table[field]) bundle_query = bundle_query.select(batch_table[field])
if txt: if txt:
txt_condition = batch_table.name.like(txt) txt_condition = batch_table.name.like("%{0}%".format(txt))
for field in searchfields + ["name"]: for field in searchfields + ["name"]:
txt_condition |= batch_table[field].like(txt) txt_condition |= batch_table[field].like("%{0}%".format(txt))
bundle_query = bundle_query.where(txt_condition) bundle_query = bundle_query.where(txt_condition)
return bundle_query return bundle_query.run(as_list=1)
@frappe.whitelist() @frappe.whitelist()