Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: typo's and parameter changes

Browse Source
This commit is contained in:
ruthra kumar 2024-01-15 14:56:51 +05:30
parent 2154502955
commit 0ec17590ae
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py
View File

@ -206,7 +206,7 @@ class PaymentReconciliation(Document):
conditions.append(jea[dimension] == self.get(dimension)) conditions.append(jea[dimension] == self.get(dimension))
if self.payment_name: if self.payment_name:
conditions.append(je.name.like(f"%%{self.payent_name}%%")) conditions.append(je.name.like(f"%%{self.payment_name}%%"))
if self.get("cost_center"): if self.get("cost_center"):
conditions.append(jea.cost_center == self.cost_center) conditions.append(jea.cost_center == self.cost_center)
@ -715,7 +715,7 @@ class PaymentReconciliation(Document):
conditions.append(je.total_debit.gte(self.minimum_payment_amount)) conditions.append(je.total_debit.gte(self.minimum_payment_amount))
if self.maximum_payment_amount: if self.maximum_payment_amount:
conditions.append(je.total_debit.lte(self.maximumb_payment_amount)) conditions.append(je.total_debit.lte(self.maximum_payment_amount))
return conditions return conditions
@ -803,6 +803,7 @@ def reconcile_dr_cr_note(dr_cr_notes, company):
inv.against_voucher, inv.against_voucher,
None, None,
inv.cost_center, inv.cost_center,
frappe._dict(),
) )

2
erpnext/accounts/utils.py
View File

@ -2046,6 +2046,8 @@ def create_gain_loss_journal(
cost_center, cost_center,
dimensions, dimensions,
) -> str: ) -> str:
# TODO: pass dimensions to Journal
journal_entry = frappe.new_doc("Journal Entry") journal_entry = frappe.new_doc("Journal Entry")
journal_entry.voucher_type = "Exchange Gain Or Loss" journal_entry.voucher_type = "Exchange Gain Or Loss"
journal_entry.company = company journal_entry.company = company