perf: use frappe.get_value with wildcard instead of another frappe.get_doc call

This commit is contained in:
Sagar Vora 2021-06-04 13:51:45 +05:30
parent 74818c7b62
commit 0e5e1350b2

View File

@ -527,7 +527,9 @@ class SalarySlip(TransactionBase):
"from_date": ("<=", date_to_validate),
"docstatus": 1,
},
"*",
order_by="from_date desc",
as_dict=True,
)
if not salary_structure_assignment:
@ -539,9 +541,7 @@ class SalarySlip(TransactionBase):
)
)
data.update(frappe.get_doc("Salary Structure Assignment",
salary_structure_assignment).as_dict())
data.update(salary_structure_assignment)
data.update(employee)
data.update(self.as_dict())