From 0c222aa50435d66520f3d504eda2008ea8926cd1 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Wed, 17 Jan 2024 20:52:16 +0530 Subject: [PATCH] fix: duplicate name error while making variant (cherry picked from commit d7e6b83e6432a6c46ce6e374252d25c0438c2205) (cherry picked from commit b649c50eccc3280168a7a69523d1aac829f4f71a) --- erpnext/controllers/item_variant.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/erpnext/controllers/item_variant.py b/erpnext/controllers/item_variant.py index ea7fb23cb6..1eee9eaa9d 100644 --- a/erpnext/controllers/item_variant.py +++ b/erpnext/controllers/item_variant.py @@ -56,7 +56,11 @@ def make_variant_based_on_manufacturer(template, manufacturer, manufacturer_part copy_attributes_to_variant(template, variant) - variant.item_code = append_number_if_name_exists("Item", template.name) + variant_name = f"{template.name} - {manufacturer}" + if manufacturer_part_no: + variant_name += f" - {manufacturer_part_no}" + + variant.item_code = append_number_if_name_exists("Item", variant_name) variant.flags.ignore_mandatory = True variant.save()