Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: eliminate unnecessary loop, container casts

Browse Source
This commit is contained in:
Ankush Menat 2021-05-22 22:59:52 +05:30
parent ad58a8164a
commit 0b4858d8e5
No known key found for this signature in database
GPG Key ID: 8EA82E09BBD13AAF
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/stock/doctype/item/item.py
View File

@ -539,10 +539,7 @@ class Item(WebsiteGenerator):
def fill_customer_code(self): def fill_customer_code(self):
""" Append all the customer codes and insert into "customer_code" field of item table """ """ Append all the customer codes and insert into "customer_code" field of item table """
cust_code = [] self.customer_code = ','.join(d.ref_code for d in self.get("customer_items", []))
for d in self.get('customer_items'):
cust_code.append(d.ref_code)
self.customer_code = ','.join(cust_code)
def check_item_tax(self): def check_item_tax(self):
"""Check whether Tax Rate is not entered twice for same Tax Type""" """Check whether Tax Rate is not entered twice for same Tax Type"""
@ -755,7 +752,7 @@ class Item(WebsiteGenerator):
template_item.save() template_item.save()
def validate_item_defaults(self): def validate_item_defaults(self):
companies = list(set([row.company for row in self.item_defaults])) companies = {row.company for row in self.item_defaults}
if len(companies) != len(self.item_defaults): if len(companies) != len(self.item_defaults):
frappe.throw(_("Cannot set multiple Item Defaults for a company.")) frappe.throw(_("Cannot set multiple Item Defaults for a company."))