From 0b293133bed2cac2564466eaa84fc0d484d8beaf Mon Sep 17 00:00:00 2001 From: mbauskar Date: Fri, 21 Apr 2017 20:05:33 +0530 Subject: [PATCH] [minor] fixes for unsupported operand type(s) for +=: 'int' and 'NoneType' --- erpnext/schools/doctype/course/course.py | 2 +- .../course_assessment_criteria.json | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/erpnext/schools/doctype/course/course.py b/erpnext/schools/doctype/course/course.py index 0ac11ec1c9..69d2fca63e 100644 --- a/erpnext/schools/doctype/course/course.py +++ b/erpnext/schools/doctype/course/course.py @@ -15,6 +15,6 @@ class Course(Document): if self.assessment_criteria: total_weightage = 0 for criteria in self.assessment_criteria: - total_weightage += criteria.weightage + total_weightage += criteria.weightage or 0 if total_weightage != 100: frappe.throw(_("Total Weightage of all Assessment Criteria must be 100%")) diff --git a/erpnext/schools/doctype/course_assessment_criteria/course_assessment_criteria.json b/erpnext/schools/doctype/course_assessment_criteria/course_assessment_criteria.json index 6646d205b5..652aa0d230 100644 --- a/erpnext/schools/doctype/course_assessment_criteria/course_assessment_criteria.json +++ b/erpnext/schools/doctype/course_assessment_criteria/course_assessment_criteria.json @@ -1,5 +1,6 @@ { "allow_copy": 0, + "allow_guest_to_view": 0, "allow_import": 0, "allow_rename": 0, "autoname": "", @@ -23,6 +24,7 @@ "ignore_user_permissions": 0, "ignore_xss_filter": 0, "in_filter": 0, + "in_global_search": 0, "in_list_view": 1, "in_standard_filter": 0, "label": "Assessment Criteria", @@ -52,6 +54,7 @@ "ignore_user_permissions": 0, "ignore_xss_filter": 0, "in_filter": 0, + "in_global_search": 0, "in_list_view": 0, "in_standard_filter": 0, "label": "", @@ -80,6 +83,7 @@ "ignore_user_permissions": 0, "ignore_xss_filter": 0, "in_filter": 0, + "in_global_search": 0, "in_list_view": 1, "in_standard_filter": 0, "label": "Weightage", @@ -92,23 +96,23 @@ "read_only": 0, "remember_last_selected_value": 0, "report_hide": 0, - "reqd": 0, + "reqd": 1, "search_index": 0, "set_only_once": 0, "unique": 0 } ], + "has_web_view": 0, "hide_heading": 0, "hide_toolbar": 0, "idx": 0, "image_view": 0, "in_create": 0, - "in_dialog": 0, "is_submittable": 0, "issingle": 0, "istable": 1, "max_attachments": 0, - "modified": "2017-02-01 18:01:40.682674", + "modified": "2017-04-21 20:04:26.621419", "modified_by": "Administrator", "module": "Schools", "name": "Course Assessment Criteria", @@ -118,6 +122,7 @@ "quick_entry": 1, "read_only": 0, "read_only_onload": 0, + "show_name_in_global_search": 0, "sort_field": "modified", "sort_order": "DESC", "track_changes": 0,