Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: failing tests

Browse Source
This commit is contained in:
Saqib Ansari 2021-12-14 20:24:29 +05:30
parent c5fcbeff7a
commit 0add80b02f
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@ -640,8 +640,6 @@ def on_communication_update(doc, status):
if not parent.meta.has_field('service_level_agreement'): if not parent.meta.has_field('service_level_agreement'):
return return
for_resolution = frappe.db.get_value('Service Level Agreement', parent.service_level_agreement, 'apply_sla_for_resolution')
if ( if (
doc.sent_or_received == "Received" # a reply is received doc.sent_or_received == "Received" # a reply is received
and parent.get('status') == 'Open' # issue status is set as open from communication.py and parent.get('status') == 'Open' # issue status is set as open from communication.py
@ -650,7 +648,11 @@ def on_communication_update(doc, status):
): ):
# undo the status change in db # undo the status change in db
# since prev status is fetched from db # since prev status is fetched from db
frappe.db.set_value(parent.doctype, parent.name, 'status', parent._doc_before_save.get('status')) frappe.db.set_value(
parent.doctype, parent.name,
'status', parent._doc_before_save.get('status'),
update_modified=False
)
elif ( elif (
doc.sent_or_received == "Sent" # a reply is sent doc.sent_or_received == "Sent" # a reply is sent
@ -665,6 +667,8 @@ def on_communication_update(doc, status):
else: else:
return return
for_resolution = frappe.db.get_value('Service Level Agreement', parent.service_level_agreement, 'apply_sla_for_resolution')
handle_status_change(parent, for_resolution) handle_status_change(parent, for_resolution)
update_response_and_resolution_metrics(parent, for_resolution) update_response_and_resolution_metrics(parent, for_resolution)
update_agreement_status(parent, for_resolution) update_agreement_status(parent, for_resolution)
@ -673,12 +677,10 @@ def on_communication_update(doc, status):
def reset_expected_response_and_resolution(doc): def reset_expected_response_and_resolution(doc):
update_values = {}
if doc.meta.has_field("first_responded_on") and not doc.get('first_responded_on'): if doc.meta.has_field("first_responded_on") and not doc.get('first_responded_on'):
update_values['response_by'] = None doc.response_by = None
if doc.meta.has_field("resolution_by") and not doc.get('resolution_date'): if doc.meta.has_field("resolution_by") and not doc.get('resolution_date'):
update_values['resolution_by'] = None doc.resolution_by = None
doc.db_set(update_values)
def set_response_by(doc, start_date_time, priority): def set_response_by(doc, start_date_time, priority):