Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: remove redundant if-statement (#30311)

Browse Source
This commit is contained in:
Raffael Meyer 2022-03-20 14:59:41 +01:00 committed by GitHub
parent c2aad115c1
commit 0a015b7f70
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
erpnext/manufacturing/doctype/production_plan/production_plan.py
View File

@ -1018,21 +1018,21 @@ def get_materials_from_other_locations(item, warehouses, new_mr_items, company):
required_qty = item.get("quantity") required_qty = item.get("quantity")
# get available material by transferring to production warehouse # get available material by transferring to production warehouse
for d in locations: for d in locations:
if required_qty <=0: return if required_qty <= 0:
return
new_dict = copy.deepcopy(item) new_dict = copy.deepcopy(item)
quantity = required_qty if d.get("qty") > required_qty else d.get("qty") quantity = required_qty if d.get("qty") > required_qty else d.get("qty")
if required_qty > 0: new_dict.update({
new_dict.update({ "quantity": quantity,
"quantity": quantity, "material_request_type": "Material Transfer",
"material_request_type": "Material Transfer", "uom": new_dict.get("stock_uom"), # internal transfer should be in stock UOM
"uom": new_dict.get("stock_uom"), # internal transfer should be in stock UOM "from_warehouse": d.get("warehouse")
"from_warehouse": d.get("warehouse") })
})
required_qty -= quantity required_qty -= quantity
new_mr_items.append(new_dict) new_mr_items.append(new_dict)
# raise purchase request for remaining qty # raise purchase request for remaining qty
if required_qty: if required_qty: