Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix for Issue #4543: Improved code to check if it's a variant only once.

Browse Source
This commit is contained in:
gabtzi 2015-12-28 11:07:10 +02:00
parent 9d44ac88f2
commit 096fc88200
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/stock/doctype/item/item.py
View File

@ -30,14 +30,15 @@ class Item(WebsiteGenerator):
self.get("__onload").sle_exists = self.check_if_sle_exists() self.get("__onload").sle_exists = self.check_if_sle_exists()
def autoname(self): def autoname(self):
if frappe.db.get_default("item_naming_by")=="Naming Series" and not self.variant_of: if frappe.db.get_default("item_naming_by")=="Naming Series":
from frappe.model.naming import make_autoname if self.variant_of:
self.item_code = make_autoname(self.naming_series+'.#####') item_code_suffix = ""
elif frappe.db.get_default("item_naming_by")=="Naming Series" and self.variant_of: for attribute in self.attributes:
item_code_suffix = "" item_code_suffix += "-" + str(attribute.attribute_value)
for attribute in self.attributes: self.item_code = str(self.variant_of) + item_code_suffix
item_code_suffix += "-" + str(attribute.attribute_value) else:
self.item_code = str(self.variant_of) + item_code_suffix from frappe.model.naming import make_autoname
self.item_code = make_autoname(self.naming_series+'.#####')
elif not self.item_code: elif not self.item_code:
msgprint(_("Item Code is mandatory because Item is not automatically numbered"), raise_exception=1) msgprint(_("Item Code is mandatory because Item is not automatically numbered"), raise_exception=1)