Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Remove redundant code

Browse Source
This commit is contained in:
Suraj Shetty 2019-06-13 17:13:54 +05:30
parent a7ac218584
commit 06f8034542
1 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
erpnext/erpnext_integrations/exotel_integration.py
View File

@ -63,24 +63,15 @@ def get_call_log(call_payload, create_new_if_not_found=True):
@frappe.whitelist() @frappe.whitelist()
def get_call_status(call_id): def get_call_status(call_id):
print(call_id) endpoint = get_exotel_endpoint('Calls/{call_id}.json'.format(call_id=call_id))
settings = get_exotel_settings() response = requests.get(endpoint)
response = requests.get('https://{api_key}:{api_token}@api.exotel.com/v1/Accounts/erpnext/Calls/{call_id}.json'.format(
api_key=settings.api_key,
api_token=settings.api_token,
call_id=call_id
))
status = response.json().get('Call', {}).get('Status') status = response.json().get('Call', {}).get('Status')
return status return status
@frappe.whitelist() @frappe.whitelist()
def make_a_call(from_number, to_number, caller_id): def make_a_call(from_number, to_number, caller_id):
settings = get_exotel_settings() endpoint = get_exotel_endpoint('Calls/connect.json?details=true')
response = requests.post('https://{api_key}:{api_token}@api.exotel.com/v1/Accounts/{sid}/Calls/connect.json?details=true'.format( response = requests.post(endpoint, data={
api_key=settings.api_key,
api_token=settings.api_token,
sid=settings.account_sid
), data={
'From': from_number, 'From': from_number,
'To': to_number, 'To': to_number,
'CallerId': caller_id 'CallerId': caller_id
@ -98,15 +89,24 @@ def get_phone_numbers():
return numbers return numbers
def whitelist_numbers(numbers, caller_id): def whitelist_numbers(numbers, caller_id):
settings = get_exotel_settings() endpoint = get_exotel_endpoint('CustomerWhitelist')
query = 'https://{api_key}:{api_token}@api.exotel.com/v1/Accounts/{sid}/CustomerWhitelist'.format( response = requests.post(endpoint, data={
api_key=settings.api_key,
api_token=settings.api_token,
sid=settings.account_sid
)
response = requests.post(query, data={
'VirtualNumber': caller_id, 'VirtualNumber': caller_id,
'Number': numbers, 'Number': numbers,
}) })
return response return response
def get_all_exophones():
endpoint = get_exotel_endpoint('IncomingPhoneNumbers')
response = requests.post(endpoint)
return response
def get_exotel_endpoint(action):
settings = get_exotel_settings()
return 'https://{api_key}:{api_token}@api.exotel.com/v1/Accounts/{sid}/{action}'.format(
api_key=settings.api_key,
api_token=settings.api_token,
sid=settings.account_sid,
action=action
)